Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explainer API for Local Classifier per parent node #minor #106

Merged
merged 68 commits into from
Mar 27, 2024
Merged

Explainer API for Local Classifier per parent node #minor #106

merged 68 commits into from
Mar 27, 2024

Conversation

ashishpatel16
Copy link
Collaborator

Hi @mirand863, this PR aims to present the first iteration of the LCPPN explainer class that enables the calculation of Shapley values for explaining predictions.

Ashish Patel and others added 30 commits January 9, 2024 22:31
added initial implementation of explainer api for lcppn
62c218d
fixed lints
ea1fff8
fixed lints
c4d75c5
@iwan-tee
added an _explain_lcppn implementation and some tests provided
299af62
modified docstrings
0ea8956
@iwan-tee
explainer for lcpn implemented + tests added and some cases fixed
1efd946
@iwan-tee
Merge branch 'explainer_api_lcpn' into explainer_api
7dcb52f
@iwan-tee
tests added + some bugs fixed
1de360c
@iwan-tee
base
933b1f6
@iwan-tee
basic implementation
c57abed
@iwan-tee
LCPL explanator implementation + test
a829ce0
added tests for hierarchy without roots
33f2cbc
@iwan-tee
check on root node added
c06d8a7
minor updates
c597fce
@iwan-tee
codestyling
b79e5f4
@iwan-tee
codestyling
8a643f1
@ashishpatel16
Merge branch 'explainer_master' into explainer_api_lcpl
606c1eb
@ashishpatel16
Update Explainer.py
ca6c654
@ashishpatel16
Merge pull request #1 from ashishpatel16/explainer_api_lcpl
9936dc3 
Explainer api lcpl
@ashishpatel16
Merge pull request #2 from ashishpatel16/explainer_api_lcpn
82573be 
Explainer api lcpn
added support for xarray for lcppn
d53e8d9
@ashishpatel16
Merge branch 'explainer_master' into explainer_api
2449928
@ashishpatel16
Update Explainer.py
759489f
@ashishpatel16
Update Explainer.py
0771c08
fixed errors with classifier with single class
4eb6f5c
updated test cases and removed cached explainers
3955521
removed cached explainers
7c2f4d2
modified predict proba to return dict
b12bdc3
@ashishpatel16
Merge branch 'main' into explainer_api
986b61c
updated get_predict_proba to return only traversed prediction probabi…
eb11c0e 
…lities
@ashishpatel16 ashishpatel16 mentioned this pull request Mar 25, 2024
Merged
@ashishpatel16
Copy link
Collaborator Author

Hi @mirand863, this PR addresses following changes -

  • Test coverage is now high (~97%). Added additional tests to cover helper functions as well.
  • Colab notebook for playing around with the LCPPN explainer code.
  • This PR only contains code, tests and docs for LCPPN.

@ashishpatel16 ashishpatel16 marked this pull request as ready for review March 25, 2024 12:58
mirand863
mirand863 requested changes Mar 25, 2024
View reviewed changes
hiclass/LocalClassifierPerParentNode.py Outdated Show resolved Hide resolved
hiclass/LocalClassifierPerParentNode.py Outdated Show resolved Hide resolved
Pipfile Outdated Show resolved Hide resolved
hiclass/Explainer.py Outdated Show resolved Hide resolved
@ashishpatel16 ashishpatel16 marked this pull request as draft March 25, 2024 15:40
@ashishpatel16 ashishpatel16 marked this pull request as ready for review March 25, 2024 17:46
mirand863
mirand863 requested changes Mar 26, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
docs/examples/plot_lcppn_explainer.py Outdated Show resolved Hide resolved
docs/requirements.txt Outdated Show resolved Hide resolved
hiclass/Explainer.py Outdated Show resolved Hide resolved
hiclass/Explainer.py Outdated Show resolved Hide resolved
docs/source/get_started/install.rst Outdated Show resolved Hide resolved
mirand863
mirand863 reviewed Mar 26, 2024
View reviewed changes
hiclass/Explainer.py Outdated Show resolved Hide resolved
@ashishpatel16 ashishpatel16 self-assigned this Mar 26, 2024
mirand863
mirand863 reviewed Mar 27, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
mirand863
mirand863 reviewed Mar 27, 2024
View reviewed changes
README.md Show resolved Hide resolved
@mirand863 mirand863 merged commit c436275 into scikit-learn-contrib:main Mar 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirand863 mirand863 mirand863 approved these changes

Assignees

@ashishpatel16 ashishpatel16

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ashishpatel16 @codecov-commenter @mirand863 @iwan-tee