[MRG] Fix test failures due to updated packages: deprecated pytest.warns(None) syntax + GLasso update in sklearn #357
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two problems due to updates in
pytest
andsklearn
:sklearn
has changed the name of the function implementing graphical lasso, which make SDML (and associated tests) fail when SKGGM is not installed. This PR makes a quick (and dirty?) fix that does the job - @perimosocordiae @terrytangyuan if you have a better solution let me knowpytest
has deprecated the syntaxpytest.warns(None)
and it raises an error since v8. I have fixed this following the guidelines provided bypytest
(Context manager to ensure no warnings are issued pytest-dev/pytest#9404 (comment)), which is to usewarnings.catch_warnings(record=True)
instead. This is what has been done for instance inscipy
(MAINT: Replace use ofpytest.warns(None)
withwarnings.catch_warnings
scipy/scipy#15192)