API - make BaseDatafit and BasePenalty regular classes
#205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into api-simplify-base-pen-df
mathurinm
approved these changes
Nov 14, 2023
|
Thanks @Badr-MOUFAD , merge when green! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context of the PR
Currently,
BaseDatafitandBasePenaltyclasses don't force their children to implement methods.It is actually impossible to enforce that by deriving Base classes from abs.ABC since Numba Jitclass still doesn't support it.
Also, several datafits and penalties diverge from the design prescribed by Base classes as they implement other methods to comply with solvers.
This PR is meant to overcome this ambiguity.
Closes #202
Contributions of the PR
@abstractclassdecorator fromBaseDatafitandBasePenaltyBaseDatafitandBasePenaltyChecks before merging PR
[ ] added documentation for any new feature[ ] added unittests