fix: Solutions to the integer linear program for fixing faulty cocyle…

… lifts are now allowed to take negative values. (#17)
scikit-tda · Aug 20, 2024 · 39f2074 · 39f2074
1 parent 1bbb8b8
commit 39f2074
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/dreimac/complexprojectivecoords.py b/dreimac/complexprojectivecoords.py
@@ -132,10 +132,13 @@ def get_coordinates(
                 n_edges = delta2.shape[1]
                 objective = np.zeros((n_edges), dtype=int)
                 integrality = np.ones((n_edges), dtype=int)
+                bounds = scipy.optimize.Bounds()  # empty bounds
+
                 optimizer_solution = milp(
                     objective,
                     integrality=integrality,
                     constraints=constraints,
+                    bounds=bounds,
                 )
 
                 if not optimizer_solution["success"]:

diff --git a/dreimac/toroidalcoords.py b/dreimac/toroidalcoords.py
@@ -148,11 +148,13 @@ def get_coordinates(
                     n_edges = delta1.shape[1]
                     objective = np.zeros((n_edges))
                     integrality = np.ones((n_edges))
+                    bounds = scipy.optimize.Bounds()  # empty bounds
 
                     optimizer_solution = milp(
                         objective,
                         integrality=integrality,
                         constraints=constraints,
+                        bounds=bounds,
                     )
 
                     if not optimizer_solution["success"]: