Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NF] Auto-encoders - streamlines - FINTA #220

Merged
merged 28 commits into from
Oct 2, 2024

Conversation

arnaudbore
Copy link
Collaborator

Description

Implementation of FINTA using dwi_ml

Testing data and script

None

Have you

  • Added a description of the content of this PR above
  • Followed proper commit message formatting
  • Added data and a script to test this PR
  • Made sure that PEP8 issues are resolved
  • Tested the code yourself right before pushing
  • Added unit tests to test the code you implemented

People this PR concerns

@EmmaRenauld

@pep8speaks
Copy link

pep8speaks commented Nov 23, 2023

Hello @arnaudbore, Thank you for updating !

Line 200:80: E501 line too long (104 > 79 characters)
Line 206:80: E501 line too long (83 > 79 characters)

Line 101:80: E501 line too long (83 > 79 characters)

Comment last updated at 2024-10-01 20:32:47 UTC

dwi_ml/training/trainers.py Outdated Show resolved Hide resolved
dwi_ml/training/trainers.py Outdated Show resolved Hide resolved
scripts_python/ae_train_model.py Outdated Show resolved Hide resolved
dwi_ml/models/projects/ae_models.py Outdated Show resolved Hide resolved
@AntoineTheb AntoineTheb self-requested a review September 17, 2024 17:57
@levje levje mentioned this pull request Sep 27, 2024
6 tasks
@arnaudbore arnaudbore changed the title [WIP][NF] Auto-encoders - streamlines - FINTA [NF] Auto-encoders - streamlines - FINTA Oct 1, 2024
@arnaudbore arnaudbore requested a review from EmmaRenauld October 1, 2024 17:38
Copy link
Collaborator

@EmmaRenauld EmmaRenauld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round of review!

Looks good!

dwi_ml/models/projects/ae_models.py Outdated Show resolved Hide resolved
dwi_ml/models/projects/ae_models.py Outdated Show resolved Hide resolved
dwi_ml/training/batch_loaders.py Outdated Show resolved Hide resolved
dwi_ml/training/trainers.py Outdated Show resolved Hide resolved
dwi_ml/models/projects/ae_models.py Show resolved Hide resolved
dwi_ml/training/trainers.py Outdated Show resolved Hide resolved
scripts_python/ae_train_model.py Show resolved Hide resolved
scripts_python/ae_train_model.py Outdated Show resolved Hide resolved
@arnaudbore arnaudbore mentioned this pull request Oct 1, 2024
@arnaudbore arnaudbore requested a review from EmmaRenauld October 1, 2024 23:29
@EmmaRenauld EmmaRenauld merged commit 04639fa into scil-vital:master Oct 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants