Merge pull request #6816 from scinote-eln/develop

December 2023 Hotfix 1
scinote-eln · Dec 13, 2023 · fe5c3a3 · fe5c3a3
2 parents f512cf4 + 795aba7
commit fe5c3a3
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/VERSION b/VERSION
@@ -1 +1 @@
-1.29.5
+1.29.5.1
diff --git a/app/jobs/my_modules/due_date_reminder_job.rb b/app/jobs/my_modules/due_date_reminder_job.rb
@@ -3,7 +3,7 @@
 module MyModules
   class DueDateReminderJob < ApplicationJob
     def perform
-      my_modules = MyModule.approaching_due_dates
+      my_modules = MyModule.uncomplete.approaching_due_dates
 
       my_modules.each do |task|
         TaskDueDateNotification.send_notifications({ my_module_id: task.id })

diff --git a/app/notifications/task_due_date_notification.rb b/app/notifications/task_due_date_notification.rb
@@ -17,6 +17,6 @@ def subject
   end
 
   after_deliver do
-    MyModule.find(params[:my_module_id]).update(due_date_notification_sent: true)
+    MyModule.find(params[:my_module_id]).update_column(:due_date_notification_sent, true)
   end
 end