Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace deprecated grpc packages #4686

Merged
merged 5 commits into from
Jan 28, 2025

Conversation

romshark
Copy link
Contributor

@romshark romshark commented Jan 27, 2025

  • replace deprecated github.com/golang/protobuf with google.golang.org/protobuf
  • replace deprecated ptypes.TimestampProto from github.com/golang/protobuf/ptypes with google.golang.org/protobuf/types/known/timestamppb
  • replace deprecated grpc.WithInsecure() with google.golang.org/grpc/credentials/insecure

Deprecation notice: https://pkg.go.dev/github.com/golang/protobuf

@romshark romshark added the refactor Change that focuses around reducing tech debt label Jan 27, 2025
@romshark romshark self-assigned this Jan 27, 2025
@romshark romshark requested review from oncilla and a team as code owners January 27, 2025 11:53
@jiceatscion
Copy link
Contributor

This change is Reviewable

@romshark romshark requested a review from jiceatscion January 27, 2025 11:53
Copy link
Contributor

@jiceatscion jiceatscion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As before... I should not approve as sole reviewer. But this sounds good. Besides my question regarding unix time. Add the change of timestamp pb to the description?

Reviewed 14 of 14 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @oncilla and @romshark)

Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 12 of 14 files at r1, 10 of 10 files at r2, 1 of 1 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jiceatscion)

@romshark romshark enabled auto-merge (squash) January 27, 2025 15:02
Copy link
Contributor

@jiceatscion jiceatscion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @romshark)

@romshark romshark merged commit c4863f5 into master Jan 28, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Change that focuses around reducing tech debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants