Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to a cleaner implementation #3

Merged
merged 40 commits into from
May 30, 2024
Merged

Refactor to a cleaner implementation #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
c044373
Allow node insertion via `map`
SimonHeybrock May 8, 2024
431158e
Improve exceptions
SimonHeybrock May 8, 2024
d39c743
Docstrings
SimonHeybrock May 8, 2024
7736e6e
Begin improving __getitem__
SimonHeybrock May 8, 2024
caf6014
Begin adding helper objects
SimonHeybrock May 14, 2024
d772388
Begin using NodeValues for validation
SimonHeybrock May 14, 2024
0946547
Move check to helper
SimonHeybrock May 14, 2024
bc1baef
Continue refactor
SimonHeybrock May 14, 2024
7695473
Continue refactor
SimonHeybrock May 16, 2024
ddc3977
Handle node value updated in most places
SimonHeybrock May 16, 2024
faf8b45
Use abc.Mapping
SimonHeybrock May 21, 2024
9d9ec55
Small fixes and cleanup
SimonHeybrock May 21, 2024
27eb425
Move to new file
SimonHeybrock May 21, 2024
e93e58f
Cleanup and fix positional slicing
SimonHeybrock May 21, 2024
a33631c
Cleanup and fixes
SimonHeybrock May 21, 2024
2f927d8
Cleanup
SimonHeybrock May 21, 2024
af8214d
Raise instead of TODO
SimonHeybrock May 21, 2024
70792f2
Fix condition
SimonHeybrock May 21, 2024
8c36e59
Turn value_attr into method arg
SimonHeybrock May 21, 2024
ebfb3d0
Avoid O(node*value_nodes) scaling
SimonHeybrock May 21, 2024
f1f335e
Remove unused
SimonHeybrock May 21, 2024
ecd65e2
Make mypy happier
SimonHeybrock May 21, 2024
bb53178
Use dataclass with slots=True
SimonHeybrock May 22, 2024
10e3425
Address cleanup comments from review
SimonHeybrock May 22, 2024
cbd97a6
Add tests demonstrating index mismatch error in compatible case
SimonHeybrock May 22, 2024
4c7190b
Minor cleanup
SimonHeybrock May 22, 2024
dfc2a70
Add and improve some tests
SimonHeybrock May 22, 2024
3c39b66
Simplify networkx usage
SimonHeybrock May 23, 2024
03ab32c
Quote node name in error message
SimonHeybrock May 23, 2024
c4d34cd
Comment on non-standard Scipp indexing notation
SimonHeybrock May 23, 2024
08c24f5
Prevent setitem with mapped nodes, which would require special handling
SimonHeybrock May 23, 2024
58b60ba
Add note
SimonHeybrock May 23, 2024
7653df6
Simplify logic
SimonHeybrock May 23, 2024
fbb2dd8
Test that node attrs are preserved
SimonHeybrock May 23, 2024
77b629e
Do not reuse variable name
SimonHeybrock May 23, 2024
7c90ff3
Cleanup adapter creation and add registry
SimonHeybrock May 23, 2024
15fdc27
Use coords as indices and fix DataArray slicing shortcomings
SimonHeybrock May 23, 2024
236ad8d
Fix return values when modules not found
SimonHeybrock May 29, 2024
ee342ab
Avoid relying on node order in tests
SimonHeybrock May 29, 2024
f0bc34d
Merge branch 'main' into cleanup
SimonHeybrock May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading