Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Q-resolution support #185

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Add Q-resolution support #185

wants to merge 11 commits into from

Conversation

SimonHeybrock
Copy link
Member

This is not ready for full review / merging, just gathering Scientist feedback

Fixes #111.

To try this out use, e.g., sans2d.ipynb and add:

workflow[sans.qresolution.SourceApertureRadius] = sc.scalar(0.020, unit='m')
workflow[sans.qresolution.SampleApertureRadius] = sc.scalar(0.008, unit='m')
workflow[sans.qresolution.CollimationLength] = sc.scalar(4.0, unit='m')
workflow[sans.qresolution.DeltaR] = sc.scalar(0.008, unit='m')
workflow[sans.qresolution.ModeratorTimeSpreadFilename] = ('ModeratorStdDev_TS2_SANS_LETexptl_07Aug2015.txt')
resolution = workflow.compute(sans.qresolution.QResolution)

Then play with resolution.bins.mean() or resolution.bins.max(). Note that if WavelengthBands is configured, the resolution is computed for each band, as one would expect.

Questions to science reviewer:

  1. Is the math correct? I have used https://docs.mantidproject.org/nightly/algorithms/TOFSANSResolutionByPixel-v1 and the linked Mantid code as a reference. Note that the docs there claim some small-angle approximation was made. I guess that is quite wrong for the Loki window-frame banks? What should we do about this?
  2. What do you require as final output? Right now I am returning binned data (see docstring), which may be useful for analysis, but I presume ultimately you need something else?

@SimonHeybrock SimonHeybrock changed the base branch from main to strip-workflow November 11, 2024 10:57
Base automatically changed from strip-workflow to main November 11, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SANS Q Resolution stored as generic function
1 participant