Skip to content

Commit

Permalink
Add support for extensions loading and creation.
Browse files Browse the repository at this point in the history
Using POSTGRESQL_LIBRARIES and POSTGRESQL_EXTENSIONS allow
users to enable extensions (some bundled in the container) without
having to do anything but adding 2 variables.
  • Loading branch information
mscherer committed Sep 15, 2021
1 parent 83c71ac commit 7b3bb19
Show file tree
Hide file tree
Showing 4 changed files with 39 additions and 2 deletions.
1 change: 1 addition & 0 deletions src/root/usr/bin/run-postgresql
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ if $PG_INITIALIZED ; then
create_users
fi

create_extensions
process_extending_files \
"${APP_DATA}/src/postgresql-start" \
"${CONTAINER_SCRIPTS_PATH}/start"
Expand Down
9 changes: 9 additions & 0 deletions src/root/usr/share/container-scripts/postgresql/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,15 @@ The following environment variables influence the PostgreSQL configuration file.
Set to an estimate of how much memory is available for disk caching by the operating system and within the database itself


The following environment variables deal with extensions. They are all optional, and if not set, no extensions will be enabled.

**`POSTGRESQL_LIBRARIES`**
A comma-separated list of libraries that Postgres will preload using shared_preload_libraries.

**`POSTGRESQL_EXTENSIONS`**
A space-separated list of extensions to create when the server start. Once created, the extensions will stay even if the variable is cleared.


You can also set the following mount points by passing the `-v /host/dir:/container/dir:Z` flag to Docker.

**`/var/lib/pgsql/data`**
Expand Down
17 changes: 17 additions & 0 deletions src/root/usr/share/container-scripts/postgresql/common.sh
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,13 @@ function should_hack_data_sync_retry() {
return 1
}

function generate_postgresql_libraries_config() {
if [ -v POSTGRESQL_LIBRARIES ]; then
echo "shared_preload_libraries='${POSTGRESQL_LIBRARIES}'" >> "${POSTGRESQL_CONFIG_FILE}"
fi
}


# New config is generated every time a container is created. It only contains
# additional custom settings and is included from $PGDATA/postgresql.conf.
function generate_postgresql_config() {
Expand All @@ -160,6 +167,7 @@ function generate_postgresql_config() {
echo "data_sync_retry = on" >>"${POSTGRESQL_CONFIG_FILE}"
fi

generate_postgresql_libraries_config
(
shopt -s nullglob
for conf in "${APP_DATA}"/src/postgresql-cfg/*.conf; do
Expand Down Expand Up @@ -478,3 +486,12 @@ process_extending_files()
done
done <<<"$(get_matched_files '*.sh' "$@" | sort -u)"
}

create_extensions()
{
if [ -v POSTGRESQL_EXTENSIONS ]; then
for EXT in $POSTGRESQL_EXTENSIONS; do
psql -c "CREATE EXTENSION IF NOT EXISTS ${EXT};"
done;
fi
}
14 changes: 12 additions & 2 deletions test/run_test
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ run_s2i_enable_ssl_test
run_upgrade_test
run_migration_test
run_pgaudit_test
run_new_pgaudit_test
"

test $# -eq 1 -a "${1-}" == --list && echo "$TEST_LIST" && exit 0
Expand All @@ -38,6 +39,8 @@ test -n "${OS-}" || false 'make sure $OS is defined'

CIDFILE_DIR=$(mktemp --suffix=postgresql_test_cidfiles -d)

DOCKER_EXTRA_ARGS=

volumes_to_clean=
images_to_clean=()
files_to_clean=
Expand Down Expand Up @@ -858,7 +861,7 @@ run_pgaudit_test()
# create a dir for config
config_dir=$(mktemp -d --tmpdir pg-hook-volume.XXXXX)
add_cleanup_command /bin/rm -rf "$config_dir"
cp -r "$test_dir"/examples/pgaudit/* "$config_dir"
$DOCKER_EXTRA_ARGS || cp -r "$test_dir"/examples/pgaudit/* "$config_dir"
setfacl -R -m u:26:rwx "$config_dir"

# create a dir for data
Expand All @@ -867,6 +870,7 @@ run_pgaudit_test()

DOCKER_ARGS="
-e POSTGRESQL_ADMIN_PASSWORD=password
$DOCKER_EXTRA_ARGS
-v ${config_dir}:/opt/app-root/src:Z
-v ${data_dir}:/var/lib/pgsql/data:Z
" create_container "$name"
Expand All @@ -878,7 +882,6 @@ run_pgaudit_test()
# Deliberately moving heredoc into the container, otherwise it does not work
# in podman 1.6.x due to https://bugzilla.redhat.com/show_bug.cgi?id=1827324
docker exec -i $(get_cid "$name") bash -c "psql <<EOSQL
CREATE EXTENSION pgaudit;
SET pgaudit.log = 'read, ddl';
CREATE DATABASE pgaudittest;
EOSQL"
Expand All @@ -898,6 +901,13 @@ EOSQL"
grep -E 'AUDIT: SESSION,.*,.*,READ,SELECT,,,SELECT' "${data_dir}"/userdata/log/postgresql-*.log
}

run_new_pgaudit_test() {
DOCKER_EXTRA_ARGS="
-e POSTGRESQL_EXTENSIONS=pgaudit
-e POSTGRESQL_LIBRARIES=pgaudit"
run_pgaudit_test
}

function run_all_tests() {
for test_case in $TEST_LIST; do
: "Running test $test_case"
Expand Down

0 comments on commit 7b3bb19

Please sign in to comment.