Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not set VERSION env var in Fedora Container files #531

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions 2.7/Dockerfile.fedora
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@ EXPOSE 8080

ENV NAME=ruby \
RUBY_VERSION=2.7 \
RUBY_SHORT_VER=27 \
VERSION=0
RUBY_SHORT_VER=27

ENV SUMMARY="Platform for building and running Ruby $RUBY_VERSION applications" \
DESCRIPTION="Ruby $RUBY_VERSION available as container is a base platform for \
Expand All @@ -25,7 +24,7 @@ LABEL summary="$SUMMARY" \
io.openshift.tags="builder,ruby,ruby${RUBY_SHORT_VER}" \
com.redhat.component="$NAME" \
name="$FGC/$NAME" \
version="$VERSION" \
version=0 \
usage="s2i build https://github.com/sclorg/s2i-ruby-container.git --context-dir=${RUBY_VERSION}/test/puma-test-app/ registry.fedoraproject.org/$FGC/ruby ruby-sample-app" \
maintainer="SoftwareCollections.org <[email protected]>"

Expand Down
5 changes: 2 additions & 3 deletions 3.0/Dockerfile.fedora
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@ EXPOSE 8080

ENV NAME=ruby \
RUBY_VERSION=3.0 \
RUBY_SHORT_VER=30 \
VERSION=0
RUBY_SHORT_VER=30

ENV SUMMARY="Platform for building and running Ruby $RUBY_VERSION applications" \
DESCRIPTION="Ruby $RUBY_VERSION available as container is a base platform for \
Expand All @@ -25,7 +24,7 @@ LABEL summary="$SUMMARY" \
io.openshift.tags="builder,ruby,ruby${RUBY_SHORT_VER}" \
com.redhat.component="$NAME" \
name="fedora/$NAME-$RUBY_SHORT_VER" \
version="$VERSION" \
version=0 \
usage="s2i build https://github.com/sclorg/s2i-ruby-container.git --context-dir=${RUBY_VERSION}/test/puma-test-app/ quay.io/fedora/$NAME-$RUBY_SHORT_VER ruby-sample-app" \
maintainer="SoftwareCollections.org <[email protected]>"

Expand Down
5 changes: 2 additions & 3 deletions 3.1/Dockerfile.fedora
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@ EXPOSE 8080

ENV NAME=ruby \
RUBY_VERSION=3.1 \
RUBY_SHORT_VER=31 \
VERSION=0
RUBY_SHORT_VER=31

ENV SUMMARY="Platform for building and running Ruby $RUBY_VERSION applications" \
DESCRIPTION="Ruby $RUBY_VERSION available as container is a base platform for \
Expand All @@ -25,7 +24,7 @@ LABEL summary="$SUMMARY" \
io.openshift.tags="builder,ruby,ruby${RUBY_SHORT_VER}" \
com.redhat.component="$NAME" \
name="fedora/$NAME-$RUBY_SHORT_VER" \
version="$VERSION" \
version=0 \
usage="s2i build https://github.com/sclorg/s2i-ruby-container.git --context-dir=${RUBY_VERSION}/test/puma-test-app/ quay.io/fedora/$NAME-$RUBY_SHORT_VER ruby-sample-app" \
maintainer="SoftwareCollections.org <[email protected]>"

Expand Down