fix(man): avoid duplicated man page and dir completions #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a directory with the same name as an already found man page candidate from manpath is present, they both end up in completions as a duplicate with the trailing slash included. To work around, skip file based completion altogether when a man page from manpath is among found candidates. A workaround for the workaround, i.e. "forcing" file based completion, is to prefix the argument with a `./`. Closes #420
|
Draft: I'm not sure I'm happy with this. Let's discuss in #420. |
scop
commented
Aug 20, 2022
| @@ -99,12 +99,12 @@ _man() | |||
| fi | |||
|
|
|||
| # shellcheck disable=SC2053 | |||
| if [[ $prev != $mansect ]]; then | |||
| # File based completion for the rest, prepending ./ if needed | |||
| if [[ $prev != $mansect && -z ${COMPREPLY-} ]]; then | |||
There was a problem hiding this comment.
We could instead loop through the completions found before start below and check and remove duplicates from file based ones, but that'd be very slow when there are lots of man page completions from man path (e.g. man <TAB> gives 9000+ on the system I'm looking at).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a directory with the same name as an already found man page candidate from manpath is present, they both end up in completions as a duplicate with the trailing slash included.
To work around, skip file based completion altogether when a man page from manpath is among found candidates. A workaround for the workaround, i.e. "forcing" file based completion, is to prefix the argument with a
./.Closes #420