Multithread fix (#2) #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix for #1 relies on comparing pthread_t, which according to pthread_equal(3) is not allowed.
This patch adds a variable thread_active which is 1 while the measurement thread is active, and is 0 otherwise. This state is tracked manually. This is required to avoid the attempt of joining a non-created thread. According to pthread_equal(3) it is not acceptable to directly compare two pthread_t, as they should be considered opaque. Hence, external tracking whether a thread is active is required. (For this reason, the hacky solution of comparing to 0 is not used, also it would probably work.) This patch further adds error checking for the final thread join. On error, errno is printed with a debug message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2.
Given there are no metrics to be recorded, no thread will be launched.
However, the final cleanup handler will still attempt to join a thread -- which then fails, as there is no thread.
This PR adds state tracking of the thread and only joins if a thread actually has been launched.