Skip to content

Commit

Permalink
🐛 fix html
Browse files Browse the repository at this point in the history
  • Loading branch information
@scottnath
scottnath committed May 17, 2024
1 parent 2cd76eb commit 7c1aa62
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 13 deletions.
2 changes: 1 addition & 1 deletion components/Education/institution.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export default function Institution(item, itemprop) {
${courses.map(
course =>
html`<li itemprop="hasCourse" itemscope itemtype="https://schema.org/Course">
<p itemprop="teaches">${markdown(course)}</p>
<p itemprop="teaches">${course}</p>
<meta itemprop="name" content="${markdown(course, true)}" />
<meta itemprop="description" content="${markdown(course, true)}" />
</li>`,
Expand Down
22 changes: 11 additions & 11 deletions test/__snapshots__/index.test.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ exports[`renders a resume 1`] = `
<h2 itemprop="jobTitle">Programmer</h2>
</div>
<img src="image.jpg" alt="Richard Hendriks's picture" itemprop="image" />
<div itemprop="description">Richard hails from Tulsa. He has earned degrees from the University of Oklahoma and Stanford. (Go Sooners and Cardinal!) Before starting Pied Piper, he worked for Hooli as a part time software developer. While his work focuses on applied information theory, mostly optimizing lossless compression schema of both the length-limited and adaptive variants, his non-work interests range widely, everything from quantum computing to chaos theory. He could tell you about it, but THAT would NOT be a “length-limited” conversation!</div>
<div itemprop="description"><p>Richard hails from Tulsa. He has earned degrees from the University of Oklahoma and Stanford. (Go Sooners and Cardinal!) Before starting Pied Piper, he worked for Hooli as a part time software developer. While his work focuses on applied information theory, mostly optimizing lossless compression schema of both the length-limited and adaptive variants, his non-work interests range widely, everything from quantum computing to chaos theory. He could tell you about it, but THAT would NOT be a “length-limited” conversation!</p></div>
<div>
<address part="contact">
<dl class="icon-list">
Expand Down Expand Up @@ -91,10 +91,10 @@ exports[`renders a resume 1`] = `
<div class="meta">
<p><time datetime="2013-12-01" itemprop="startDate">Dec 2013</time> – <time datetime="2014-12-01" itemprop="endDate">Dec 2014</time></p> <p>Palo Alto, CA</p>
</div>
<div itemprop="description">Pied Piper is a multi-platform technology based on a proprietary universal compression algorithm that has consistently fielded high Weisman Scores™ that are not merely competitive, but approach the theoretical limit of lossless compression.</div>
<div itemprop="description"><p>Pied Piper is a multi-platform technology based on a proprietary universal compression algorithm that has consistently fielded high Weisman Scores™ that are not merely competitive, but approach the theoretical limit of lossless compression.</p></div>
<ul>
<li itemprop="disambiguatingDescription">Build an algorithm for artist to detect if their music was violating copy right infringement laws</li><li itemprop="disambiguatingDescription">Successfully won Techcrunch Disrupt</li><li itemprop="disambiguatingDescription">Optimized an algorithm that holds the current world record for Weisman Scores</li>
<li itemprop="disambiguatingDescription"><p>Build an algorithm for artist to detect if their music was violating copy right infringement laws</p></li><li itemprop="disambiguatingDescription"><p>Successfully won Techcrunch Disrupt</p></li><li itemprop="disambiguatingDescription"><p>Optimized an algorithm that holds the current world record for Weisman Scores</p></li>
</ul>
</section>
Expand All @@ -110,10 +110,10 @@ exports[`renders a resume 1`] = `
<section itemprop="employee" itemscope itemtype="https://schema.org/OrganizationRole">
<h5 itemprop="roleName">Teacher</h5>
<p><time datetime="2012-01-01" itemprop="startDate">Jan 2012</time> – <time datetime="2013-01-01" itemprop="endDate">Jan 2013</time></p>
<div itemprop="description">Global movement of free coding clubs for young people.</div>
<div itemprop="description"><p>Global movement of free coding clubs for young people.</p></div>
<ul>
<li itemprop="description">Awarded 'Teacher of the Month'</li>
<li itemprop="description"><p>Awarded 'Teacher of the Month'</p></li>
</ul>
</section>
Expand All @@ -126,7 +126,7 @@ exports[`renders a resume 1`] = `
<h4><a href="https://www.ou.edu/" itemprop="url"><span itemprop="name">University of Oklahoma</span></a></h4>
<section itemprop="owns" itemscope itemtype="https://schema.org/EducationalOccupationalProgram">
<h5 itemprop="occupationalCategory">Information Technology</h5>
<div itemprop="educationalProgramMode">Bachelor</div>
<div itemprop="educationalProgramMode"><p>Bachelor</p></div>
<p><time datetime="2011-06-01" itemprop="startDate">Jun 2011</time> – <time datetime="2014-01-01" itemprop="endDate">Jan 2014</time></p>
<ul>
Expand Down Expand Up @@ -154,7 +154,7 @@ exports[`renders a resume 1`] = `
<dd class="meta">
<div>Awarded by <strong>Techcrunch</strong></div> <time datetime="2014-11-01" >Nov 2014</time>
</dd>
<dd>There is no spoon.</dd>
<dd><p>There is no spoon.</p></dd>
</div>
</dl>
Expand All @@ -170,7 +170,7 @@ exports[`renders a resume 1`] = `
Published by <strong itemprop="name">Hooli</strong>
</dd>
<dd class="meta" itemprop="dateCreated"><time datetime="2014-10-01" >Oct 2014</time></dd>
<dd itemprop="abstract">Innovative middle-out compression algorithm that changes the way we store data.</dd>
<dd itemprop="abstract"><p>Innovative middle-out compression algorithm that changes the way we store data.</p></dd>
</div>
</dl>
Expand Down Expand Up @@ -218,7 +218,7 @@ exports[`renders a resume 1`] = `
<div class="stack">
<blockquote itemprop="subjectOf" itemscope itemtype="https://schema.org/Statement">
<div itemprop="text">It is my pleasure to recommend Richard, his performance working as a consultant for Main St. Company proved that he will be a valuable addition to any company.</div>
<div itemprop="text"><p>It is my pleasure to recommend Richard, his performance working as a consultant for Main St. Company proved that he will be a valuable addition to any company.</p></div>
<p itemprop="author" itemscope itemtype="https://schema.org/Person">
<cite itemprop="name">Erlich Bachman</cite>
Expand All @@ -238,7 +238,7 @@ exports[`renders a resume 1`] = `
<span itemprop="name">Smoogle</span>
</p>
<p itemprop="additionalType">application</p>
<div class="meta" itemprop="description">A mapping engine that misguides you</div>
<div class="meta" itemprop="description"><p>A mapping engine that misguides you</p></div>
<div class="meta">
<ul itemprop="keywords" class="tag-list">
<li>GoogleMaps</li><li>Chrome Extension</li><li>Javascript</li>
Expand All @@ -251,7 +251,7 @@ exports[`renders a resume 1`] = `
<p><time datetime="2016-08-24" itemprop="startDate">Aug 2016</time> – <time datetime="2016-08-24" itemprop="endDate">Aug 2016</time></p>
<ul>
<li itemprop="description">Won award at AIHacks 2016</li><li itemprop="description">Built by all women team of newbie programmers</li><li itemprop="description">Using modern technologies such as GoogleMaps, Chrome Extension and Javascript</li>
<li itemprop="description"><p>Won award at AIHacks 2016</p></li><li itemprop="description"><p>Built by all women team of newbie programmers</p></li><li itemprop="description"><p>Using modern technologies such as GoogleMaps, Chrome Extension and Javascript</p></li>
</ul>
</section>
Expand Down
2 changes: 1 addition & 1 deletion test/index.test.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,6 @@ it('renders valid HTML', async () => {
const {
results: [{ messages } = {}],
} = await htmlvalidate.validateString(render(resume))

console.log(messages)
expect(messages).toBeUndefined()
})

0 comments on commit 7c1aa62

Please sign in to comment.