Fixed backup directory not being created #334
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, ran into this one. Got around it by making the directory before running. |
This user is found on SteamOS, but can't be used. Shortcuts are created, but will never be used by a user.
|
Thanks for doing this! I actually just finished up a refactor of the backups logic (mostly to add a bunch more tests), so this issue should be fixed now. I actually added a couple tests to make sure this doesnt regress specifically. Thanks a bunch for contributing though :D. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I encountered #325 on SteamOS, I made a pr with this fix. It makes shortcuts_back_path function in configuration.py create the required directories for doing backups.