Strongly Typed Ledger Object wrapper for DepositPreAuth #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Keylet is used to distinguish between various other types of SLEs
…t does not apply the new wrapper extensively across the codebase. That would need a closer examination in a separate commit.
|
I'm aware that I need to organize the wrapper in disparate files. I thought I'll do it after the initial code review |
…ositPreAuth into the new read, peek functions
…ction calls corresponding to Checks ledger objects
… wrapper function calls.
This commit defines and uses a new wrapper for the Offers Ledger Object. It is a sequel to the continuing work in the series of Account, DepositPreauth and Checks. Existing usages of readSLE and peekSLE relevant to the Offers object have been modified to use read and peek functions respectively. This brings forth the compile-time type checking advantages offered by the proposed Strongly typed wrapper. As part of future work, DeleteAccount.cpp needs to be updated to ensure that std::shared_ptr<SLE> is removed in favor of the new wrapper. This requires changes to other ledger objects like NFTokens.
This commit introduces a new wrapper for Escrow ledger objects through a strongly-typed Escrow keylet. Existing instances of readSLE and peekSLE pertaining to Escrow objects have been updated to use newly proposed read/peek functions. The wrapper exposes read APIs into the erstwhile STObject::at(...) interface.
|
Superseded by pull request #18. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Context of Change
Type of Change
Test Plan
DepositPreAuth already has unit tests. Since I'm not exposing any new public API endpoints, I'm not sure if/how newer unit tests need to be added.
Future Tasks
I need to organize the DepositPreAuthorize wrapper into a separate file. At the moment, I'm piggy-backing on AccountRoot file, I'll change this after the initial code review.