Strongly typed wrapper for Checks Ledger Object #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit includes type-aliases for read-only and writable checks. It also formats all files as per git-clang-format convention
ckeshava
commented
Jun 7, 2023
| return wrapped_->at(~sfExpiration); | ||
| } | ||
|
|
||
| // Keshava: This function is identical to the function |
There was a problem hiding this comment.
I need your suggestions for updating the below two functions names and also their definitions. Let me know if the existing version is alright.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit includes implementation for the wrapper and possible usages of read/peek functions at appropriate points in the codebase
High Level Overview of Change
Context of Change
Type of Change