Pay chan wrap #20
Open
Pay chan wrap #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces implementation for the said wrapper. Occurences of PayChan keylet have been modified to indicate the new type. One function in PayChan_test.cpp:channelAndSle(...) uses the readSLE API. It has a dependency on inOwnerDir(...) function. This can be ported only after completion of the Directory ledger object wrapper.
ckeshava
commented
Jun 7, 2023
| @@ -44,6 +44,8 @@ struct PayChan_test : public beast::unit_test::suite | |||
| return k.key; | |||
| } | |||
|
|
|||
| // Keshava: Modify this function to use read() after keylet::ownerDir has | |||
There was a problem hiding this comment.
is it okay if I leave this comment in? I don't want to forget this particular instance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces wrapper for Payment Channels Ledger Object.
High Level Overview of Change
Context of Change
Type of Change
Test Plan
I have not included any new unit tests. Since this is an internal refactor, existing test cases should suffice in validating the new changes. As part of future work, additional test cases can be added pertaining to the APIs of newly added classes.