Signers Ledger Object wrapper #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckeshava
commented
May 30, 2023
| @@ -182,7 +182,7 @@ removeSignersFromLedger( | |||
| ApplyView& view, | |||
| AccountRootKeylet const& accountKeylet, | |||
| Keylet const& ownerDirKeylet, | |||
| Keylet const& signerListKeylet, | |||
| KeyletBase const& signerListKeylet, | |||
There was a problem hiding this comment.
I think I can specialize this parameter to SignersKeylet. Should I do that or leave it as is? Since this function is specific to signers, I don't think there is any harm in narrowing it's scope.
Narrow down the scope of type in function signature of removeSignersFromLedger
replace auto keyword with explicit type information rename variables to indicate difference between SLE pointers and LederEntry Wrappers
Fix errors in access to getFieldU32, isFieldPresent functions in Transactors format the code according to clang-format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces wrapper for Multi-Signer List Ledger Object.
High Level Overview of Change
Context of Change
Type of Change