Strongly typed wrapper for Negative UNL Ledger Object #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckeshava
commented
May 31, 2023
src/ripple/app/ledger/Ledger.cpp
Outdated
| @@ -737,10 +737,10 @@ Ledger::negativeUNL() const | |||
| std::optional<PublicKey> | |||
| Ledger::validatorToDisable() const | |||
| { | |||
| if (auto sle = readSLE(keylet::negativeUNL()); | |||
| sle && sle->isFieldPresent(sfValidatorToDisable)) | |||
| if (auto nUNLLedgerObj = read<NegUNLKeylet, NegUNLImpl<false>>(keylet::negativeUNL()); | |||
There was a problem hiding this comment.
I don't remember the details, but the compiler was throwing an error without an explicit specialization of the read<> function template. I'll investigate if I can remove the verbosity.
ckeshava
commented
Jun 1, 2023
src/ripple/protocol/NegativeUNL.h
Outdated
| #define RIPPLE_PROTOCOL_NEGATIVE_UNL_H_INCLUDED | ||
|
|
||
| #include <ripple/protocol/LedgerEntryWrapper.h> | ||
| //#include <ripple/protocol/STAccount.h> |
There was a problem hiding this comment.
i forgot to remove these comments, will do while addressing the PR comments. I hope that's ok
ckeshava
commented
Jun 1, 2023
src/ripple/protocol/NegativeUNL.h
Outdated
| } | ||
|
|
||
| [[nodiscard]] bool | ||
| isFieldPresent(SField const& field) const { |
There was a problem hiding this comment.
My understanding is that the NegativeUNL and Amendments ledger objects are singletons. Hence, there is possibility of re-writing some of these functions as static functions.
But I'm not sure if that is a good design decision.
- Remove old comments - Update copyrights information to year 2023 - Include explicit type information instead of using auto keyword
…inside the codebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change