Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strongly Typed Wrapper for Escrow objects #27

Open
wants to merge 2 commits into
base: wrapper
Choose a base branch
from

Conversation

ckeshava
Copy link

@ckeshava ckeshava commented Jun 8, 2023

This commit introduces a new wrapper for Escrow ledger objects through a strongly-typed Escrow keylet. Existing instances of readSLE and peekSLE pertaining to Escrow objects have been updated to use newly proposed read/peek functions.

The wrapper exposes read APIs into the erstwhile STObject::at(...) interface.

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

ckeshava added 2 commits June 8, 2023 10:11
This commit introduces a new wrapper for Escrow ledger objects through a strongly-typed Escrow keylet. Existing instances of readSLE and peekSLE pertaining to Escrow objects have been updated to use newly proposed read/peek functions.

The wrapper exposes read APIs into the erstwhile STObject::at(...) interface.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant