Fix #9

CHANGELOG.md

@@ -4,6 +4,17 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.1.3] - 2023-06-23
+
+### Changed
+
+- Add test cases for the Dataview plugin.
+- Add test cases for tables which contain aliased links.
+
+### Fixed
+
+- Fix aliased link detection for the Dataview plugin. #9.
+
 ## [1.1.2] - 2023-05-07
 
 ### Changed

manifest.json

@@ -3,7 +3,7 @@
 	"name": "Short links",
 	"description": "An Obsidian plugin to display short internal links.",
 	"author": "Scott Moore",
-	"version": "1.1.2",
+	"version": "1.1.3",
 	"minAppVersion": "1.1.1",
 	"isDesktopOnly": false
 }

notes/Dataview.md

@@ -0,0 +1,21 @@
+#dataview 
+
+# Data
+
+[[Australia]]
+[[Australia#Victoria]]
+[[Australia#^states-and-territories]]
+
+[[Australia|AUS]]
+[[Australia#Victoria|VIC]]
+[[Australia#^states-and-territories|States and Territories]]
+
+[[Australia|<]]
+[[Australia#Victoria|<<]]
+[[Australia#^states-and-territories|<<<]]
+
+# View
+
+```dataview
+TABLE file.outlinks FROM #dataview
+```

notes/Tables.md

@@ -0,0 +1,19 @@
+NOTE: Aliased links appear to break tables...
+
+| Link | Link |
+| --- | --- |
+| [[Australia]] |  [[Australia]] |
+| [[Australia#Victoria]] | [[Australia#Victoria]] |
+| [[Australia#^states-and-territories]] | [[Australia#^states-and-territories]] |
+
+| Link | Aliased Link |
+| --- | --- |
+| [[Australia]] | [[Australia|AUS]] |
+| [[Australia#Victoria]] | [[Australia#Victoria|VIC]] |
+| [[Australia#^states-and-territories]] | [[Australia#^states-and-territories|States and Territories]] |
+
+| Aliased Link | Link |
+| --- | --- |
+| [[Australia|AUS]] | [[Australia]] |
+| [[Australia#Victoria|VIC]] | [[Australia#Victoria]] |
+| [[Australia#^states-and-territories|States and Territories]] | [[Australia#^states-and-territories]] |

package.json

@@ -4,7 +4,7 @@
 	"description": "An Obsidian plugin to display short internal links.",
 	"author": "Scott Moore",
 	"license": "MIT",
-	"version": "1.1.2",
+	"version": "1.1.3",
 	"scripts": {
 		"build": "node --require esbuild-register scripts/build.ts",
 		"format": "prettier --write .",

sources/markdownPostProcessor.ts

@@ -33,13 +33,24 @@ export const createMarkdownPostProcessor: CreateMarkdownPostProcessor = (plugin)
 		const link = linkElement.getAttribute("href");
 		if (link === null) continue;
 
-		const isAlias = linkElement.hasAttribute("aria-label");
+		// NOTE: There is no easy way to detect whether a link is an alias or
+		// not. At the moment, the only way to detect whether a link is an
+		// alias is to check whether the `aria-label` attribute exists.
+		// However, this does not work in rare cases, for example in the
+		// Dataview plugin.  Therefore, we also must check whether the
+		// attribute is different from  the link text and also strip any file
+		// names! At the moment we just remove all instances of `.md`, however
+		// this is not a perfect solution.
+
+		const ariaLabel = linkElement.getAttribute("aria-label");
+		const expectedText = ariaLabel?.replace(".md", "");
+		const isAlias = expectedText !== linkElement.getText();
 
 		const internalLink = parseInternalLink(link);
 
 		if (configuration.shortLinksToFiles && !isAlias) {
-			const fileNameText = sliceText(link, internalLink.fileName);
-			linkElement.setText(fileNameText);
+			const fileBaseText = sliceText(link, internalLink.fileBase);
+			linkElement.setText(fileBaseText);
 		}
 
 		switch (internalLink.type) {

versions.json

@@ -4,5 +4,6 @@
 	"1.0.2": "0.16.3",
 	"1.1.0": "1.1.1",
 	"1.1.1": "1.1.1",
-	"1.1.2": "1.1.1"
+	"1.1.2": "1.1.1",
+	"1.1.3": "1.1.1"
 }