Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Scala 2.13 #110

Closed
wants to merge 4 commits into from
Closed

Conversation

eyalroth
Copy link
Contributor

Fixes #106.
Fixes #109.

Still depends on upgrading the plugin to support version 1.4.0 of the scalac plugin, as there is no other version available for Scala 2.13. See #107.

Also removes a functional test for multi-language support, which I believe was added following #102, but is unnecessary as there is already a functional test for that.

@maiflai
Copy link
Contributor

maiflai commented Nov 19, 2019

support for 2.13 now on master?

@maiflai maiflai closed this Nov 19, 2019
@eyalroth
Copy link
Contributor Author

@maiflai Did you manually added these changes as commits on master or as part of the 1.4 PR?

I'm not seeing the changes of commit 64ad30e from this PR (the deletion of a redundant functional test).

We should also close #106 and #109 (I don't have the permissions).

@maiflai
Copy link
Contributor

maiflai commented Nov 20, 2019

sorry, yes - merged locally and I must have missed the removal of the functional test.

I tend to close the issues after a release and confirmation that they are really closed. I didn't
have time to watch the build earlier today, I'll take a closer look at the failure.

thanks very much for all your work on this, it's much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not work with 2.13 Could not resolve org.scoverage:scalac-scoverage-plugin_2:1.3.1
2 participants