Properly close sources from files #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdedetrich
force-pushed
the
properly-close-source-files
branch
from
128ebfd to
6284495
Compare
rolandtritsch
approved these changes
Jan 24, 2025
|
@mdedetrich Did also cut a new release to make the improvements available to everybody. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intellij picked this up when inspecting the codebase, there are a lot of cases of creating a
BufferedSourcefrom a file usingscala.io.Sourcebut not properly closing the file in all cases (i.e. if there is an exception) which can lead to file handle leaks.As another improvement, we use
scala.util.control.NonFatalsince when you catch exceptions you should only be catching the ones that make sense to catch.