fix(3226): refactor verify method to throw an error when pod is in the unknown waiting state #199
+99
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VonnyJap
changed the title
VonnyJap
changed the title
VonnyJap
changed the title
|
|
||
| waitingReason = hoek.reach(p, CONTAINER_WAITING_REASON_PATH); | ||
| if (status === 'running' || status === 'succeeded') { |
There was a problem hiding this comment.
message value is set but will never be used
|
|
||
| // data is not undefined when desired status or waitingReason met | ||
| // hence no error needs to be thrown | ||
| if (data !== undefined) { |
There was a problem hiding this comment.
we want to fix this inconsistent return from the function, consider returning an obj with message and verify status and use it in worker to decide retry plus log the message
pritamstyz4ever
requested changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
_verifymethod fails to provide proper error handling during a situation when the pod is not in a running condition hence missing the retry mechanism and causing the build stuck in a dangling situation.Objective
_verifymethod refactoring to throw an error if the pod is not running or succeeded, enabling a retry mechanism, i.e. when pod is initializing or in a state of waiting.References
screwdriver-cd/screwdriver#3226
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.