feat(3277): Support banner display in the UI pipeline landing page #1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagar1312
force-pushed
the
sagar1312-feat-3277-pipeline_banners
branch
3 times, most recently
from
fafba75 to
e4b6e4c
Compare
VonnyJap
reviewed
Feb 3, 2025
sagar1312
force-pushed
the
sagar1312-feat-3277-pipeline_banners
branch
from
e4b6e4c to
a750699
Compare
sagar1312
force-pushed
the
sagar1312-feat-3277-pipeline_banners
branch
from
a750699 to
7efea61
Compare
minghay
requested changes
Feb 3, 2025
There was a problem hiding this comment.
Use a Glimmer component for the banner
| @@ -0,0 +1,20 @@ | |||
| {{#each this.banners as |banner|}} | |||
There was a problem hiding this comment.
Suggested change
| {{#each this.banners as |banner|}} | |
| {{#each @banners as |banner|}} |
There was a problem hiding this comment.
You'll need to modify the stylesheet to use SASS syntax for the variables and to properly export the style sheet to be included
| @@ -36,6 +36,15 @@ export default class PipelineOptionsRoute extends Route { | |||
| return []; | |||
| }); | |||
|
|
|||
| return { pipeline, jobs }; | |||
| const banners = await this.shuttle | |||
There was a problem hiding this comment.
Banners shouldn't be fetched in this route for the V2 UI
| @@ -1,9 +1,9 @@ | |||
| & { | |||
| .banner .alert { | |||
| height: $nav-banner-height; | |||
There was a problem hiding this comment.
You need to readjust the spacing allocated to the banners in the CSS variables since having multiple banners in the current implementation will break the page experience forcing a vertical scroll on the page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Banner messages can now be created for specific pipeline.
Such banners are not currently rendered in the UI.
Objective
Fetch and render pipeline specific banners messages in pipeline pages.
References
screwdriver-cd/screwdriver#3277
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.