feat(L1 state manager): L1Reader #1018

NazariiDenha · 2024-09-01T21:31:12Z

1. Purpose or design rationale of this PR

This PR implements L1Reader: a streamlined way to read L1 data without worrying about type of events and logs. It also utilizes the L1Reader in the L1 follower mode syncing pipeline to greatly simplify the code.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
docs: Documentation-only changes
feat: A new feature
fix: A bug fix
perf: A code change that improves performance
refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
Yes

4. Breaking change label

Does this PR have the breaking-change label?

This PR is not a breaking change
Yes

Conflicts: cmd/geth/main.go core/state_processor_test.go core/txpool/legacypool/legacypool.go eth/backend.go eth/ethconfig/config.go eth/gasprice/gasprice_test.go eth/handler.go eth/protocols/eth/broadcast.go eth/protocols/eth/handlers.go go.mod go.sum miner/miner.go miner/miner_test.go miner/scroll_worker.go miner/scroll_worker_test.go params/config.go params/version.go rollup/rollup_sync_service/rollup_sync_service_test.go

semgrep-app · 2024-09-01T21:32:42Z

Semgrep found 6 ssc-46663897-ab0c-04dc-126b-07fe2ce42fb2 findings:

rollup/da_syncer/blob_client/block_native_client.go
- L31 - Triage
rollup/da_syncer/blob_client/blob_scan_client.go
- L33 - Triage
- L38 - Triage
rollup/da_syncer/blob_client/beacon_node_client.go
- L35 - Triage
- L62 - Triage
- L102 - Triage

Risk: Affected versions of golang.org/x/net, golang.org/x/net/http2, and net/http are vulnerable to Uncontrolled Resource Consumption. An attacker may cause an HTTP/2 endpoint to read arbitrary amounts of header data by sending an excessive number of CONTINUATION frames.

Fix: Upgrade this library to at least version 0.23.0 at go-ethereum/go.mod:144.

Reference(s): GHSA-4v7x-pqxf-cx7m, CVE-2023-45288

_{Ignore this finding from ssc-46663897-ab0c-04dc-126b-07fe2ce42fb2.}

rollup/l1_state_tracker/l1_reader.go

rollup/l1_state_tracker/l1_tracker.go

…service

rollup/l1/tracker.go

rollup/l1/reader.go

…ests

…1-state-tracker

coderabbitai · 2024-10-24T00:54:11Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

…1-state-tracker

semgrep-app · 2024-11-28T03:53:48Z

Semgrep found 6 ssc-46663897-ab0c-04dc-126b-07fe2ce42fb2 findings:

rollup/da_syncer/blob_client/block_native_client.go
- L33 - Triage
rollup/da_syncer/blob_client/blob_scan_client.go
- L35 - Triage
- L40 - Triage
rollup/da_syncer/blob_client/beacon_node_client.go
- L35 - Triage
- L65 - Triage
- L108 - Triage

Risk: Affected versions of golang.org/x/net, golang.org/x/net/http2, and net/http are vulnerable to Uncontrolled Resource Consumption. An attacker may cause an HTTP/2 endpoint to read arbitrary amounts of header data by sending an excessive number of CONTINUATION frames.

Fix: Upgrade this library to at least version 0.23.0 at go-ethereum/go.mod:145.

Reference(s): GHSA-4v7x-pqxf-cx7m, CVE-2023-45288

_{Ignore this finding from ssc-46663897-ab0c-04dc-126b-07fe2ce42fb2.}

rollup/l1/abi.go

jonastheis · 2024-12-10T09:16:26Z

Replaced by #1099

jonastheis and others added 6 commits August 29, 2024 12:34

fixes after merge

11e440b

fix: panic after startup due to misconfigured api

2ee38fd

fix bug of not calculating block state root

9e8afc4

minor adjustment of fix

6068db3

add l1_tracker and l1_reader without caching

117016e

fix incorrect depth calc

271b7dc

jonastheis reviewed Sep 2, 2024

View reviewed changes

jonastheis and others added 4 commits September 3, 2024 16:34

refactor: rename package to l1

f9111cb

refactor reader to process raw logs to rollup events

0fc3b94

refactor da_syncer to not use depend on rollup_sync_service and sync_…

5b22f7f

…service

feat: implement tracker

27c5d63

jonastheis force-pushed the feat/l1-state-tracker branch from 95027f5 to 27c5d63 Compare September 4, 2024 11:04

NazariiDenha commented Sep 4, 2024

View reviewed changes

rollup/l1/tracker.go Outdated Show resolved Hide resolved

fetch in batches

fa09f3f

jonastheis reviewed Sep 5, 2024

View reviewed changes

rollup/l1/reader.go Show resolved Hide resolved

jonastheis and others added 6 commits September 5, 2024 15:30

feat: add test cases for happy path and fix minor bugs uncovered by t…

6686d1d

…ests

feat: add test for confirmation rules when subscribing

15ea17e

add extensive tests for reorgs

dbafb2c

adjust interface to be the same as reth ex ex but with block headers

10a8b64

fixes

854dc43

pruning

294b9c6

Base automatically changed from feat/sync-directly-from-da-rebased to syncUpstream/active October 16, 2024 02:11

jonastheis added 2 commits October 23, 2024 12:02

Merge remote-tracking branch 'origin/syncUpstream/active' into feat/l…

6464296

…1-state-tracker

fixes after merge

79842f8

jonastheis force-pushed the feat/l1-state-tracker branch from cd0eb14 to 79842f8 Compare October 23, 2024 04:15

jonastheis added 3 commits October 23, 2024 12:43

extend Reader

a45885e

simplify as functionality has been moved to Reader

1b5a4f8

Merge remote-tracking branch 'origin/syncUpstream/active' into feat/l…

acb1bc2

…1-state-tracker

fix using outdated ABI for L1MessageQueue

591534c

jonastheis added 3 commits October 29, 2024 07:36

Add LatestFinalizedBatch

c96a3da

Fix bug in queryInBatches

113241e

add HeapMap component

e873ac0

jonastheis changed the title ~~feat: L1 state manager(reduce bridge latency milestone)~~ feat(L1 state manager): L1Reader Nov 28, 2024

jonastheis added 3 commits November 28, 2024 11:39

remove state tracker and move to separate branch

bbd7144

add some tests

b895b43

Merge remote-tracking branch 'origin/syncUpstream/active' into feat/l…

31f0bfe

…1-state-tracker

jonastheis marked this pull request as ready for review November 28, 2024 03:56

jonastheis approved these changes Nov 28, 2024

View reviewed changes

colinlyguo approved these changes Nov 28, 2024

View reviewed changes

rollup/l1/abi.go Show resolved Hide resolved

rollup/l1/abi.go Show resolved Hide resolved

jonastheis added a commit that referenced this pull request Dec 10, 2024

port changes from #1018

4d5b802

jonastheis mentioned this pull request Dec 10, 2024

feat: L1Reader #1099

Open

13 tasks

jonastheis closed this Dec 10, 2024

jonastheis added a commit that referenced this pull request Dec 11, 2024

port changes from #1018

da9610f

jonastheis added a commit that referenced this pull request Dec 12, 2024

port changes from #1018

8d18b5e

jonastheis added a commit that referenced this pull request Dec 12, 2024

port changes from #1018

b918a2b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(L1 state manager): L1Reader #1018

feat(L1 state manager): L1Reader #1018

NazariiDenha commented Sep 1, 2024 •

edited by jonastheis

Loading

semgrep-app bot commented Sep 1, 2024

coderabbitai bot commented Oct 24, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

semgrep-app bot commented Nov 28, 2024

jonastheis commented Dec 10, 2024

feat(L1 state manager): L1Reader #1018

feat(L1 state manager): L1Reader #1018

Conversation

NazariiDenha commented Sep 1, 2024 • edited by jonastheis Loading

1. Purpose or design rationale of this PR

2. PR title

3. Deployment tag versioning

4. Breaking change label

semgrep-app bot commented Sep 1, 2024

coderabbitai bot commented Oct 24, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

semgrep-app bot commented Nov 28, 2024

jonastheis commented Dec 10, 2024

NazariiDenha commented Sep 1, 2024 •

edited by jonastheis

Loading

coderabbitai bot commented Oct 24, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)