feat(permissionless batches): block production without signature #1087

jonastheis · 2024-11-04T01:31:31Z

1. Purpose or design rationale of this PR

This PR enables creating blocks without a valid signature. This is necessary in permissionless mode for anyone to be able to produce blocks without having access to the latest valid key according to Clique consensus.

It is part of the permissionless batch production toolkit together with #1073 and scroll-tech/scroll#1555

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
docs: Documentation-only changes
feat: A new feature
fix: A bug fix
perf: A code change that improves performance
refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
Yes

4. Breaking change label

Does this PR have the breaking-change label?

This PR is not a breaking change
Yes

coderabbitai · 2024-11-04T01:31:36Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

…ty field in header

…producing blocks

…ry' into jt/permissionless-batches-recovery-mine

georgehao · 2024-11-19T06:49:19Z

eth/backend.go

@@ -562,7 +567,10 @@ func (s *Ethereum) Protocols() []p2p.Protocol {
 // Start implements node.Lifecycle, starting all internal goroutines needed by the
 // Ethereum protocol implementation.
 func (s *Ethereum) Start() error {
-	eth.StartENRUpdater(s.blockchain, s.p2pServer.LocalNode())
+	// handler is not enabled when DA syncing enabled
+	if !s.config.EnableDASyncing {


Why disable when DA syncing

there's a nil pointer downstream when mining blocks without the networking layer being initialized

jonastheis · 2025-02-13T09:09:07Z

Superseded by #1117

* port changes from #1013 * port changes from #1068 * go.mod tidy * fix compile error * fix goimports * fix log * address review comments * upgrade golang.org/x/net to 0.23.0 * port changes from #1018 * fix tests and linter errors * address review comments * refactor rollup sync service / verifier to use CalldataBlobSource to retrieve data from L1 * add configuration and initialize blob clients * fix unit tests * remove unused code * address review comments * address more review comments * implement first version of new da-codec and to handle multiple batches submitted in one transaction * add CommitBatchDAV7 and handle multiple commit events submitted in a single transactions * fix bug due to previous batch being empty when processing the first batch within a set of batches * Allow using MPT * update to latest da-codec * add field to CommittedBatchMeta to store LastL1MessageQueueHash for CodecV7 batches * adjust rollup verifier to support CodecV7 batches * address review comments * fix issues after merge * go mod tidy * fix unit tests * update da-codec * add test TestValidateBatchCodecV7 * go mod tidy * do not log error on shutdown * add sanity check for version to deserialization of committedBatchMetaV7 * port changes from #1073 * chore: auto version bump [bot] * address review comments * add more logs * disable ENRUpdater if DA sync mode is enabled * exit pipeline if context is cancelled * correctly handle override by setting the head of the chain to the parent's height so that created blocks will always become part of canonical chain * fix error with genesis event being nil * rebase #1087 to new base branch * chore: auto version bump [bot] --------- Co-authored-by: Ömer Faruk Irmak <[email protected]> Co-authored-by: Thegaram <[email protected]> Co-authored-by: jonastheis <[email protected]> Co-authored-by: Péter Garamvölgyi <[email protected]>

add option to disable signing for Scroll worker

80816b5

jonastheis added 4 commits November 18, 2024 16:11

fix error where only a single block was mined due to missing difficul…

cbf5592

…ty field in header

sanity check config values and properly hook up syncing manager when …

7056a14

…producing blocks

Merge remote-tracking branch 'origin/jt/permissionless-batches-recove…

d7a8506

…ry' into jt/permissionless-batches-recovery-mine

fixes after merge

533f75d

georgehao reviewed Nov 19, 2024

View reviewed changes

colinlyguo approved these changes Nov 19, 2024

View reviewed changes

jonastheis mentioned this pull request Nov 21, 2024

feat(permissionless batches): batch production toolkit and operator recovery scroll-tech/scroll#1555

Draft

13 tasks

jonastheis added a commit that referenced this pull request Feb 13, 2025

rebase #1087 to new base branch

9533eab

jonastheis mentioned this pull request Feb 13, 2025

feat(permissionless batches): block production without signature #1117

Merged

3 tasks

jonastheis closed this Feb 13, 2025

jonastheis deleted the jt/permissionless-batches-recovery-mine branch February 13, 2025 09:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(permissionless batches): block production without signature #1087

feat(permissionless batches): block production without signature #1087

jonastheis commented Nov 4, 2024 •

edited

Loading

coderabbitai bot commented Nov 4, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

georgehao Nov 19, 2024

jonastheis Nov 21, 2024

jonastheis commented Feb 13, 2025

feat(permissionless batches): block production without signature #1087

feat(permissionless batches): block production without signature #1087

Conversation

jonastheis commented Nov 4, 2024 • edited Loading

1. Purpose or design rationale of this PR

2. PR title

3. Deployment tag versioning

4. Breaking change label

coderabbitai bot commented Nov 4, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

georgehao Nov 19, 2024

Choose a reason for hiding this comment

jonastheis Nov 21, 2024

Choose a reason for hiding this comment

jonastheis commented Feb 13, 2025

jonastheis commented Nov 4, 2024 •

edited

Loading

coderabbitai bot commented Nov 4, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)