Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contracts): remove proof verification on finalizeBatchWithProof #1003

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

zimpha
Copy link
Member

@zimpha zimpha commented Oct 31, 2023

Purpose or design rationale of this PR

We won't provide the proof generation service for sepolia testnet. This PR will allow finalizeBatchWithProof without providing real proof.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • feat: A new feature

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change

@zimpha zimpha self-assigned this Oct 31, 2023
@zimpha zimpha requested review from Thegaram and icemelon and removed request for Thegaram October 31, 2023 05:55
@github-actions
Copy link

github-actions bot commented Oct 31, 2023

LCOV of commit 67d5a86 during Contracts #120

Summary coverage rate:
  lines......: 51.0% (1014 of 1989 lines)
  functions..: 65.0% (227 of 349 functions)
  branches...: no data found

Files changed coverage rate: n/a

@georgehao georgehao merged commit 20ea287 into sepolia Nov 6, 2023
3 checks passed
@georgehao georgehao deleted the feat/auto_finalize_sepolia branch November 6, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants