Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (contracts): update verifier contract to mainnet version v0.9.8 #1049

Merged
merged 6 commits into from
Dec 18, 2023

Conversation

silathdiir
Copy link
Contributor

@silathdiir silathdiir commented Dec 13, 2023

Purpose or design rationale of this PR

Update verifier contract to v0.9.8. No need to deploy, just update the code to avoid confusing for who read our code.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ef673c9) 48.90% compared to head (b47d271) 48.92%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1049      +/-   ##
===========================================
+ Coverage    48.90%   48.92%   +0.01%     
===========================================
  Files          158      158              
  Lines        12710    12705       -5     
===========================================
  Hits          6216     6216              
+ Misses        6064     6059       -5     
  Partials       430      430              
Flag Coverage Δ
contracts 53.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@silathdiir silathdiir changed the title fix: ugprade verifier contract to v0.9.8 fix (contracts): ugprade verifier contract to v0.9.8 Dec 13, 2023
@silathdiir silathdiir requested a review from zimpha December 13, 2023 13:30
@silathdiir silathdiir requested a review from lispc December 14, 2023 03:11
@silathdiir silathdiir changed the title fix (contracts): ugprade verifier contract to v0.9.8 fix (contracts): update verifier contract to v0.9.8 Dec 17, 2023
@silathdiir silathdiir requested a review from icemelon December 17, 2023 03:15
@lispc lispc changed the title fix (contracts): update verifier contract to v0.9.8 fix (contracts): update verifier contract to mainnet version v0.9.8 Dec 17, 2023
@icemelon icemelon merged commit 03089ea into develop Dec 18, 2023
11 checks passed
@icemelon icemelon deleted the upgrade-verifier-contract-to-v0.9.8 branch December 18, 2023 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants