Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toastr sound #978

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Toastr sound #978

wants to merge 5 commits into from
+95 −42

Conversation

csachdeva83
Copy link

@cherishSachdeva
Howler & Sound
198aa83 
* Install howler package
* Add error.mp3 and success.mp3 files
@cherishSachdeva
Sound
7e3c938 
* Add error,info,success,warning.mp3 sounds
* Create toast type and sound map
* Play sound in openToast method
@cherishSachdeva
Enable Sound Option
52c4341 
* Enable & Disable Sound option add in home html
* Add enableSound key in interface IndividualConfig
* Default enableSound is false
@cherishSachdeva
Add enableSound in README.md
4dee521
@codecov
Copy link

codecov bot commented Feb 25, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 55.49%. Comparing base (efaf809) to head (e5325d9).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
src/app/home/home.component.ts 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #978      +/-   ##
==========================================
+ Coverage   55.11%   55.49%   +0.37%     
==========================================
  Files          19       19              
  Lines         508      510       +2     
  Branches       88       89       +1     
==========================================
+ Hits          280      283       +3     
- Misses        216      217       +1     
+ Partials       12       10       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@csachdeva83
Copy link
Author

@scttcper Please review this PR and list out any changes you desire.

@scttcper
Copy link
Owner

its interesting, but i don't think it belongs as part of the toastr

@csachdeva83
Copy link
Author

its interesting, but i don't think it belongs as part of the toastr

Why so ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@csachdeva83 @scttcper @cherishSachdeva