Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove out of core median #3379

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

remove out of core median #3379

wants to merge 2 commits into from

Conversation

Intron7
Copy link
Member

@Intron7 Intron7 commented Nov 21, 2024

Computing counts per cell for normalize_total leads to better performance.

@Intron7 Intron7 added this to the 1.11.0 milestone Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.44%. Comparing base (8ce811a) to head (becdd21).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3379      +/-   ##
==========================================
- Coverage   75.44%   75.44%   -0.01%     
==========================================
  Files         113      113              
  Lines       13250    13248       -2     
==========================================
- Hits         9997     9995       -2     
  Misses       3253     3253              
Files with missing lines Coverage Δ
src/scanpy/preprocessing/_normalization.py 81.39% <100.00%> (-0.43%) ⬇️

@flying-sheep
Copy link
Member

Fair enough. Can this blow up? I.e. is counts ever big enough that this is a problem?

@flying-sheep flying-sheep modified the milestones: 1.11.0, 1.12.0 Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants