-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace custom attrdict
with ml_collections
implementation.
#1696
Conversation
Codecov ReportBase: 90.71% // Head: 90.84% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1696 +/- ##
==========================================
+ Coverage 90.71% 90.84% +0.12%
==========================================
Files 116 116
Lines 9791 9764 -27
==========================================
- Hits 8882 8870 -12
+ Misses 909 894 -15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Seems that |
attrdict
with ml_collections
implementation.attrdict
with ml_collections
implementation.
…s into wip-1690-mlcollections
attrdict
with ml_collections
implementation.attrdict
with ml_collections
implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #1690.