Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #3061 on branch 1.2.x (feat: Support for minification in totalVI) #3077

Merged

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #3061: feat: Support for minification in totalVI

@lumberbot-app lumberbot-app bot added this to the scvi-tools 1.2 milestone Dec 4, 2024
@lumberbot-app lumberbot-app bot added cuda tests Run test suite on CUDA on-merge: backport to 1.2.x on-merge: backport to 1.2.x labels Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 88.97638% with 14 lines in your changes missing coverage. Please review.

Project coverage is 84.44%. Comparing base (63c8681) to head (bf64a79).
Report is 1 commits behind head on 1.2.x.

Files with missing lines Patch % Lines
src/scvi/model/base/_base_model.py 86.84% 5 Missing ⚠️
src/scvi/model/utils/_minification.py 80.00% 4 Missing ⚠️
src/scvi/module/_totalvae.py 91.17% 3 Missing ⚠️
src/scvi/data/_utils.py 66.66% 1 Missing ⚠️
src/scvi/model/_totalvi.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            1.2.x    #3077      +/-   ##
==========================================
+ Coverage   84.37%   84.44%   +0.06%     
==========================================
  Files         173      173              
  Lines       14799    14872      +73     
==========================================
+ Hits        12487    12559      +72     
- Misses       2312     2313       +1     
Files with missing lines Coverage Δ
src/scvi/model/_scanvi.py 95.23% <100.00%> (-0.69%) ⬇️
src/scvi/model/_scvi.py 95.91% <100.00%> (+0.08%) ⬆️
src/scvi/model/_utils.py 92.61% <100.00%> (+2.89%) ⬆️
src/scvi/model/base/__init__.py 100.00% <100.00%> (ø)
src/scvi/model/base/_de_core.py 97.50% <100.00%> (+0.16%) ⬆️
src/scvi/model/utils/__init__.py 100.00% <100.00%> (ø)
src/scvi/data/_utils.py 85.11% <66.66%> (-0.43%) ⬇️
src/scvi/model/_totalvi.py 87.29% <92.30%> (+0.46%) ⬆️
src/scvi/module/_totalvae.py 88.01% <91.17%> (+0.47%) ⬆️
src/scvi/model/utils/_minification.py 84.37% <80.00%> (-8.96%) ⬇️
... and 1 more

... and 2 files with indirect coverage changes

@canergen canergen merged commit a387c9b into scverse:1.2.x Dec 4, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda tests Run test suite on CUDA on-merge: backport to 1.2.x on-merge: backport to 1.2.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants