Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add github action workflows to update README on DockerHub #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CodeLieutenant
Copy link
Collaborator

@CodeLieutenant CodeLieutenant commented Nov 26, 2024

  • Update README and make it a basic documentation for running cassandra-stress.
  • README is propagated to DockerHub where cassandra-stress image is uploaded after release

Closes #5

@CodeLieutenant CodeLieutenant added the documentation Improvements or additions to documentation label Nov 26, 2024
@CodeLieutenant CodeLieutenant requested a review from fruch November 26, 2024 12:49
@CodeLieutenant CodeLieutenant self-assigned this Nov 26, 2024
README.md Show resolved Hide resolved
.github/workflows/docker.yml Outdated Show resolved Hide resolved
@fruch
Copy link

fruch commented Dec 2, 2024

@annastuchlik

we want to embed this one into core docs as well
in scylladb/scylladb#21723

any advise on how to keep them in sync ? maybe just reference this repo from the core docs ?

@CodeLieutenant
Copy link
Collaborator Author

@annastuchlik

we want to embed this one into core docs as well in scylladb/scylladb#21723

any advise on how to keep them in sync ? maybe just reference this repo from the core docs ?

The main issue is that core docs are written in RST, and this one is in Markdown, Dockerhub does not support RST (tried it first), so keeping them in sync is a bit tricky, unless we do some translation between the two. Just referencing this page, does not look good on documentation site.

I can try something with GitHub Actions to translate MD to RST and open PR to core repo with DIFF from Markdown. Is that ok solution @fruch?

@annastuchlik
Copy link

we want to embed this one into core docs as well in scylladb/scylladb#21723

any advise on how to keep them in sync ? maybe just reference this repo from the core docs ?

Instead of duplicating content, I would add a reference in the core documentation. I think we should create a new page, briefly describe what cassandra-stress is used for, and add the links to:

  • the cassandra-stress repository
  • the page on DockerHub

Apart from the duplication, there are more reasons not to mix the two docs sets, such as different versioning and quality policies. For example, user-facing documentation shouldn't include information such as The latest version of cassandra-stress at the time of writing this document is 3.17.0. Please check the latest version on . . . .
In fact, we shouldn't mention versions in versioned documentation.

@annastuchlik
Copy link

@CodeLieutenant @fruch
I've confirmed with @tzach that we want to stick to our policies: projects should contain their own documentation (i.e., we should not document external tools in the ScyllaDB core documentation). We have two options:

  • Create a separate minisite for cassandra-stress (cassandra-stress.scylladb.com), but there isn't enough content to justify that.
  • Add the links to this repo and DockerHub to the ScyllaDB documentation.

We should do the latter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update the readme/dockerhub to match what is this repository
3 participants