Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add complex types support and tests #71

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Bouncheck
Copy link
Collaborator

@Bouncheck Bouncheck commented May 9, 2022

See commit message.

@avelanarius
Copy link

Please add "Fixes #60" to the commit message.

Please add documentation (somewhere in README) about this new support and all supported types.

@Bouncheck Bouncheck force-pushed the complex-types branch 2 times, most recently from 9e1356a to c9965a8 Compare May 17, 2022 09:52
@Bouncheck Bouncheck changed the title Add UDT support and map tests Add complex types support and tests May 17, 2022
Adds support for all Collections (List, Set, Map), UDT and Tuples.

Adds tests that attempt inserting into columns of complex type.
Those tests check if implemented codecs kick in when needed.

Kafka Struct fields get translated into UDTs. Connector will try to infer correct
UserType from table column. If table does not exist yet or is
being altered the connector will try to find UserType with the same
name as struct's schema. In all cases the UserType needs to already
be created in targeted keyspace.

Kafka Maps get translated into Scylla maps, some can be inserted into UDTs.
Kafka Arrays can be inserted into Lists, Sets and Tuples.
Kafka Structs can be inserted into UDTs and Tuples.

Updates README with basic information about supported types on Scylla side.

All added types should work with table managed by Scylla.
UDTs, Maps, Lists, Sets should work with table managed by connector.

Fixes scylladb#60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants