-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(BaseMonitorSet): Implement monitoring template #9855
Conversation
5f70e7b
to
9b4018c
Compare
@k0machi new branch |
448e001
to
a6f5dac
Compare
Added annotations, template variables for event types, added logic to change default values (currently just hardcoded to change the |
This run has the updated dashboard, monitoring node is set to |
a6f5dac
to
9eeebf4
Compare
requests served per instance shows whole numbers (like 30000 instead of 30k) and miss unit (ops/s) |
b5847d4
to
e0def3f
Compare
Fixed |
I'll update the template based on recent changes by Valerii and then we can merge this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Still docker provision test fails with c-s.
@dimakr do you know what could be the reason?
it's cause of counters, we need to drop them from those tests. since we move to take latest scylla release (with tablets enabled by default), it's kind of broken EDIT: I did handled a part of it, skipping the pre-create of counter table when tablets is enabled, but that wasn't enough |
Will rebase onto #10006 and update with changes from recent stress-command panels merge. |
e0def3f
to
c93bfd7
Compare
942d773
to
1bc4693
Compare
This commit adds a new templating mechanism for monitoring dashboards, allowing SCT to be in sync with changes in scylla-monitoring repo, by first separating SCT metrics into a separate file, and then injecting them into the overview template on the monitoring node, then regenerating said template. This allows monitoring dashboard to always be up to date with regards to changes on the monitoring side. Fixes scylladb/qa-tasks#1444
1bc4693
to
3811063
Compare
Latest run that implements the new dash. Grafana node is still up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This commit adds a new templating mechanism for monitoring dashboards,
allowing SCT to be in sync with changes in scylla-monitoring repo, by
first separating SCT metrics into a separate file, and then injecting
them into the overview template on the monitoring node, then
regenerating said template. This allows monitoring dashboard to always
be up to date with regards to changes on the monitoring side.
Fixes scylladb/qa-tasks#1444
Testing
PR pre-checks (self review)
backport
labelsReminders
sdcm/sct_config.py
)unit-test/
folder)