Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify docs index pages and make sure they are always in sync with the menu #1509

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

tnozicka
Copy link
Contributor

Description of your changes:
This PR makes sure, that our toctree in the left menu matches the index pages and removes the inconsistencies, like when some links were named differently. This also eliminates the possibility that we miss some links that are present in the menu.

While it's not as pretty as when written manually, the consistency should prevail + I've filed scylladb/sphinx-scylladb-theme#935

/cc @rzetelskik
(on your request)

@tnozicka tnozicka added kind/documentation Categorizes issue or PR as related to documentation. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Oct 25, 2023
@scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2023
@tnozicka tnozicka changed the title Unify index pages and make sure they are always in sync with the menu Unify docs index pages and make sure they are always in sync with the menu Oct 25, 2023
@scylla-operator-bot scylla-operator-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 25, 2023
@rzetelskik
Copy link
Member

Thanks Tomas
/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2023
@scylla-operator-bot scylla-operator-bot bot merged commit 0790ea3 into scylladb:master Nov 1, 2023
@tnozicka tnozicka deleted the unify-index-pages branch November 1, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants