cicd: fix authenticate tests #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkropachev
force-pushed
the
dk/fix-authenticate_test
branch
from
277b454 to
457fe8e
Compare
|
|
muzarski
reviewed
Jan 23, 2025
dkropachev
force-pushed
the
dk/fix-authenticate_test
branch
13 times, most recently
from
398db7f to
265ed29
Compare
dkropachev
force-pushed
the
dk/fix-authenticate_test
branch
from
265ed29 to
003eef7
Compare
dkropachev
force-pushed
the
dk/fix-authenticate_test
branch
2 times, most recently
from
bb92874 to
28317c1
Compare
wprzytula
requested changes
Jan 26, 2025
dkropachev
force-pushed
the
dk/fix-authenticate_test
branch
2 times, most recently
from
696b9ec to
d0d535b
Compare
wprzytula
previously approved these changes
Jan 29, 2025
Lorak-mmk
reviewed
Jan 29, 2025
muzarski
approved these changes
Jan 29, 2025
github action services do not provide api to change entrypoint. We need to switch to docker-compose to spin up docker container for auth tests.
dkropachev
force-pushed
the
dk/fix-authenticate_test
branch
from
d0d535b to
8890d12
Compare
Lorak-mmk
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github actions do not have API to override entrypoint, we have to switch to
docker-composeto start container for auth tests.Pre-review checklist
I added relevant tests for new features and bug fixes.All commits compile, pass static checks and pass test.I have provided docstrings for the public items that I want to introduce.I have adjusted the documentation in./docs/source/.I added appropriateFixes:annotations to PR description.