Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mdx): #277 directory import error on next.js pages router #291

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

sdorra
Copy link
Owner

@sdorra sdorra commented Sep 5, 2024

Use full path to mdx-bundler client include index.js,
instead of only the directory.

This should fix the usage of mdx package in next.js pages router.
Add a sample which uses tge next.js pages router.

Use full path to mdx-bundler client include index.js,
instead of only the directory.
This should fix the usage of mdx package in next.js pages router.

Closes: #277
@sdorra sdorra added bug Something isn't working preview-release Deploy a preview release labels Sep 5, 2024
@sdorra sdorra self-assigned this Sep 5, 2024
Copy link

vercel bot commented Sep 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
content-collections ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2024 2:06pm

Copy link

changeset-bot bot commented Sep 5, 2024

⚠️ No Changeset found

Latest commit: 6568348

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Sep 5, 2024

Open in Stackblitz

@content-collections/cli

pnpm add https://pkg.pr.new/sdorra/content-collections/@content-collections/cli@291

@content-collections/core

pnpm add https://pkg.pr.new/sdorra/content-collections/@content-collections/core@291

@content-collections/integrations

pnpm add https://pkg.pr.new/sdorra/content-collections/@content-collections/integrations@291

@content-collections/markdown

pnpm add https://pkg.pr.new/sdorra/content-collections/@content-collections/markdown@291

@content-collections/mdx

pnpm add https://pkg.pr.new/sdorra/content-collections/@content-collections/mdx@291

@content-collections/next

pnpm add https://pkg.pr.new/sdorra/content-collections/@content-collections/next@291

@content-collections/remix-vite

pnpm add https://pkg.pr.new/sdorra/content-collections/@content-collections/remix-vite@291

@content-collections/vite

pnpm add https://pkg.pr.new/sdorra/content-collections/@content-collections/vite@291

@content-collections/solid-start

pnpm add https://pkg.pr.new/sdorra/content-collections/@content-collections/solid-start@291

commit: 6568348

Copy link

pkg-pr-new bot commented Sep 5, 2024

Open in Stackblitz

@content-collections/cli

pnpm add https://pkg.pr.new/sdorra/content-collections/@content-collections/cli@291

@content-collections/integrations

pnpm add https://pkg.pr.new/sdorra/content-collections/@content-collections/integrations@291

@content-collections/core

pnpm add https://pkg.pr.new/sdorra/content-collections/@content-collections/core@291

@content-collections/markdown

pnpm add https://pkg.pr.new/sdorra/content-collections/@content-collections/markdown@291

@content-collections/next

pnpm add https://pkg.pr.new/sdorra/content-collections/@content-collections/next@291

@content-collections/mdx

pnpm add https://pkg.pr.new/sdorra/content-collections/@content-collections/mdx@291

@content-collections/remix-vite

pnpm add https://pkg.pr.new/sdorra/content-collections/@content-collections/remix-vite@291

@content-collections/solid-start

pnpm add https://pkg.pr.new/sdorra/content-collections/@content-collections/solid-start@291

@content-collections/vite

pnpm add https://pkg.pr.new/sdorra/content-collections/@content-collections/vite@291

commit: 6568348

Copy link

pkg-pr-new bot commented Sep 5, 2024

Open in Stackblitz

@content-collections/cli

pnpm add https://pkg.pr.new/sdorra/content-collections/@content-collections/cli@291

@content-collections/core

pnpm add https://pkg.pr.new/sdorra/content-collections/@content-collections/core@291

@content-collections/integrations

pnpm add https://pkg.pr.new/sdorra/content-collections/@content-collections/integrations@291

@content-collections/markdown

pnpm add https://pkg.pr.new/sdorra/content-collections/@content-collections/markdown@291

@content-collections/next

pnpm add https://pkg.pr.new/sdorra/content-collections/@content-collections/next@291

@content-collections/mdx

pnpm add https://pkg.pr.new/sdorra/content-collections/@content-collections/mdx@291

@content-collections/remix-vite

pnpm add https://pkg.pr.new/sdorra/content-collections/@content-collections/remix-vite@291

@content-collections/solid-start

pnpm add https://pkg.pr.new/sdorra/content-collections/@content-collections/solid-start@291

@content-collections/vite

pnpm add https://pkg.pr.new/sdorra/content-collections/@content-collections/vite@291

commit: 6568348

@sdorra sdorra merged commit fd7f11d into main Sep 12, 2024
9 checks passed
@sdorra sdorra deleted the feature/277_mdx_next_pages branch September 12, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working preview-release Deploy a preview release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant