Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in a sub directory are treated as new documents on windows #383

Merged
merged 12 commits into from
Nov 2, 2024

Conversation

sdorra
Copy link
Owner

@sdorra sdorra commented Oct 30, 2024

The globbing library used (tinyglobby) always returns paths with POSIX separators.
This creates problems when a path is generated by the watcher,
which uses the OS-specific separator.
As a result, the file may not be found in the collection if the path separators differ.

This PR also contains changes to fix the unit tests on Windows and run the CI pipeline on Windows as well.

Closes #373

The globbing library used (tinyglobby) always returns paths with POSIX separators.
This creates problems when a path is generated by the watcher,
which uses the OS-specific separator.
As a result, the file may not be found in the collection if the path separators differ.

Closes: #373
@sdorra sdorra added the bug Something isn't working label Oct 30, 2024
@sdorra sdorra self-assigned this Oct 30, 2024
Copy link

changeset-bot bot commented Oct 30, 2024

⚠️ No Changeset found

Latest commit: ecc9c98

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
content-collections ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 2, 2024 8:54pm

Copy link

pkg-pr-new bot commented Oct 30, 2024

Open in Stackblitz

@content-collections/cli

pnpm add https://pkg.pr.new/sdorra/content-collections/@content-collections/cli@383

@content-collections/core

pnpm add https://pkg.pr.new/sdorra/content-collections/@content-collections/core@383

@content-collections/integrations

pnpm add https://pkg.pr.new/sdorra/content-collections/@content-collections/integrations@383

@content-collections/markdown

pnpm add https://pkg.pr.new/sdorra/content-collections/@content-collections/markdown@383

@content-collections/mdx

pnpm add https://pkg.pr.new/sdorra/content-collections/@content-collections/mdx@383

@content-collections/next

pnpm add https://pkg.pr.new/sdorra/content-collections/@content-collections/next@383

@content-collections/remix-vite

pnpm add https://pkg.pr.new/sdorra/content-collections/@content-collections/remix-vite@383

@content-collections/solid-start

pnpm add https://pkg.pr.new/sdorra/content-collections/@content-collections/solid-start@383

@content-collections/vite

pnpm add https://pkg.pr.new/sdorra/content-collections/@content-collections/vite@383

commit: 9c80f20

Increase the timeout for waitUntil to 5 seconds
and increase the retries from 3 to 5
in order to make the tests pass on the Windows CI server.
We now run CI tests on Windows, so we no longer need the mocked path tests.
@sdorra sdorra force-pushed the bugfix/373_unit_tests_on_windows branch from 9f11122 to ecc9c98 Compare November 2, 2024 20:53
@sdorra sdorra merged commit 528d0ec into main Nov 2, 2024
7 checks passed
@sdorra sdorra deleted the bugfix/373_unit_tests_on_windows branch November 2, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

duplicate documents getting generated on save
2 participants