support for unsorted sets within zinterstore/zunionstore #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinnymz
force-pushed
the
add_set_support_for_zinterstore_zunionstore
branch
from
bf33411 to
3c5e9fd
Compare
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per Redis Labs documentation, zinterstore and zunionstore should support passing unsorted sets to these commands with an implicit score of 1.0 applied to all values within the set.
Curiously, the ZINTERSTORE and ZUNIONSTORE command documentation make no mention of this. However, as referenced above this is officially supported, and patches ensuring this behavior have been merged accordingly.
This patch adds this functionality to the
.zinterstoreand.zunionstoremethods so it will behave as Redis itself would.