Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support terminology codes #106
feat: support terminology codes #106
Changes from all commits
8b17610
42d8635
48cd565
b90072d
5c93ea4
024bc2e
fc886b2
8d59c3e
acac519
37f5150
8e528a4
1363d6c
49a2ad6
2169165
53dbc84
ab0a807
2ab52c7
85e3ea5
653c73a
a85dc51
5afc4ef
8df4cf3
b4eeb47
8d9deb2
772b47c
06ca00b
ac78fa1
4b9c8af
2e5590f
270aec0
7dd1c6e
f827c30
234524d
e672524
9cec345
091c7bd
8685064
74524e4
17c0309
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question(clarification): the config template provides both a public & local setup. How is this config used exactly to make sure that we're dealing with either public or local setup? The main reason I'm asking is if it makes more sense to separate the two into different files or make it clearer what needs to be modified in which case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the "public" urls are the service addresses outside the compose network, whereas the "local" urls are their addresses within the compose network.
Generally, there are two options:
http://<server-name>/<service-name>
http://<service-name>:<service-port>
http://<external-service>:<service-port>
http://<external-service>:<service-port>
I'll try to make that clearer in the docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documented in 06ca00b
@marftn do you think this whole thing makes sense, or is this some kind of antipattern?