Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): pin htsget version + bump msrv #49

Merged
merged 2 commits into from
May 27, 2024
Merged

fix(server): pin htsget version + bump msrv #49

merged 2 commits into from
May 27, 2024

Conversation

cmdoret
Copy link
Member

@cmdoret cmdoret commented May 27, 2024 •
edited
Loading

htsget minimum supported rust version (msrv) is now 1.75, but our htsget service used 1.74 as the base layer.

This PR pins htsget to the latest release and bumps the MSRV in our base layer.

@cmdoret cmdoret self-assigned this May 27, 2024
@cmdoret cmdoret added the bug Something isn't working label May 27, 2024
@almutlue almutlue self-requested a review May 27, 2024 15:44
almutlue
almutlue approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@almutlue almutlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @cmdoret!
Looks good and reasonable to me. Deployment and streaming works seamless as before on my side!

@cmdoret cmdoret merged commit 65dbc0e into main May 27, 2024
3 checks passed
@cmdoret cmdoret deleted the fix/htsget-msrv branch July 3, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almutlue almutlue almutlue approved these changes

Assignees

@cmdoret cmdoret

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmdoret @almutlue