Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): reload minio filesystem for each server query #62

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

cmdoret
Copy link
Member

@cmdoret cmdoret commented Jun 7, 2024

The modo server did not register MODOs created after startup. This was due to the s3Fs object caching the filesystem state on instantiation by default.

This adds the refresh=True option to always refresh the filesystem when the server receives http requests.

Fixes #59

@cmdoret cmdoret added the bug Something isn't working label Jun 7, 2024
@cmdoret cmdoret requested a review from almutlue June 7, 2024 14:47
@cmdoret cmdoret self-assigned this Jun 7, 2024
Copy link
Contributor

@almutlue almutlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice and well spotted! Also works on my side with a local minio deployment and modos.remote.list_remote_items("http://localhost")

@cmdoret cmdoret merged commit fa47a1a into main Jun 10, 2024
3 checks passed
@cmdoret cmdoret deleted the fix/minio-refresh branch June 14, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/meta endpoint broken in REST API
2 participants