Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update mermaid to 1.1.1 #12

Merged
merged 1 commit into from
Jun 6, 2024
Merged

chore(deps): update mermaid to 1.1.1 #12

merged 1 commit into from
Jun 6, 2024

Conversation

almutlue
Copy link
Contributor

@almutlue almutlue commented Jun 6, 2024

Version fix to properly render broken mermaid diagrams in the docs:

mkdocs-mermaid2-plugin 0.6.0 --> 1.1.1

The version update locally solved the problem (when running make testdoc).

@almutlue almutlue added the bug Something isn't working label Jun 6, 2024
@almutlue almutlue self-assigned this Jun 6, 2024
@almutlue almutlue linked an issue Jun 6, 2024 that may be closed by this pull request
Fix broken mermaid dependency #11
Closed
@almutlue almutlue requested a review from cmdoret June 6, 2024 06:37
cmdoret
cmdoret approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@cmdoret cmdoret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎 Good call, works on my end as well!

@almutlue almutlue merged commit 1afa734 into main Jun 6, 2024
2 checks passed
@almutlue almutlue deleted the fix/mermaid_version branch June 6, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmdoret cmdoret cmdoret approved these changes

Assignees

@almutlue almutlue

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix broken mermaid dependency
2 participants
@almutlue @cmdoret