Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing first_release in targetdb.targeting_generation peewee ORM #283

Merged
merged 3 commits into from
Feb 11, 2025
Merged

Missing first_release in targetdb.targeting_generation peewee ORM #283

merged 3 commits into from
Feb 11, 2025

Conversation

imedan
Copy link
Contributor

@imedan imedan commented Feb 11, 2025

Fixes #282

@imedan imedan requested review from albireox and tdwelly February 11, 2025 16:55
@imedan imedan requested a review from havok2063 as a code owner February 11, 2025 16:55
albireox
albireox requested changes Feb 11, 2025
View reviewed changes
Copy link
Member

@albireox albireox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add the column here

sdssdb/python/sdssdb/sqlalchemy/sdss5db/targetdb.py

Line 372 in b653038

class TargetingGeneration(Base):

I think the error in the test can be ignored, it doesn't seem related. Other than that it looks good.

@imedan imedan merged commit 59be29a into main Feb 11, 2025
1 of 2 checks passed
@imedan imedan deleted the target_generation branch February 11, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albireox albireox albireox approved these changes

@tdwelly tdwelly Awaiting requested review from tdwelly

@havok2063 havok2063 Awaiting requested review from havok2063 havok2063 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing first_release in targetdb.targeting_generation peewee ORM
2 participants
@imedan @albireox