-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 5.0 #280
Version 5.0 #280
Conversation
This includes reading and storing the data as well as building author and artifact networks. Signed-off-by: Christian Hechtl <[email protected]> Applied-by: Leo Sendelbach <[email protected]>
Also removed comments and browser statements, as well as added updating of commit-interaction data when commit data is changed if commit-interactions are configured Signed-off-by: Leo Sendelbach <[email protected]>
outdated comment with local data path removed Signed-off-by: Leo Sendelbach <[email protected]>
Uses 'equals' function on Project Data with new commit-interactions Signed-off-by: Leo Sendelbach <[email protected]>
new test reads commit-interactions data and asserts its correctness Signed-off-by: Leo Sendelbach <[email protected]>
An empty file and an example file with four interactions Signed-off-by: Leo Sendelbach <[email protected]>
Checks that the empty dataframe has correct col and rownames Signed-off-by: Leo Sendelbach <[email protected]>
Test that commit-interactions are updated when they are configured and commit data is changed Signed-off-by: Leo Sendelbach <[email protected]>
Also added some linebreaks Signed-off-by: Leo Sendelbach <[email protected]>
in 'update.commit.interactions' Signed-off-by: Leo Sendelbach <[email protected]>
using 'expect_false(isTRUE(all.equal(x, y)))' Signed-off-by: Leo Sendelbach <[email protected]>
Also change the test to reflect this change Signed-off-by: Leo Sendelbach <[email protected]>
'update.commit.interactions' no longer duplicates 'base.author' and 'interacting.author' columns Signed-off-by: Leo Sendelbach <[email protected]>
The merge now always keeps all commit interactions, even if there is no commit data for them (for example if the commits were made by deleted users). Also introduced a warning if that happens. Case is tested with new part in 'test-data.R' Signed-off-by: Leo Sendelbach <[email protected]>
columns 'base.author' and 'interacting.author' are initialized as NA and will be overwritten in 'update.commit.interactions'. Also, introduce check for correctness of returned data frame at the end of 'read.commit.interactions'. Signed-off-by: Leo Sendelbach <[email protected]>
Test now checks for 'base.author' and 'interacting.author' as intended Signed-off-by: Leo Sendelbach <[email protected]>
Function removes lines from commit-interactions that do not contain an author in either 'base.author' or 'interacting.author' Signed-off-by: Leo Sendelbach <[email protected]>
Test that a line is removed from a data frame with a missing author Signed-off-by: Leo Sendelbach <[email protected]>
Test easy construction of an author network with interaction as relation Signed-off-by: Leo Sendelbach <[email protected]>
Also in 'get.artifact.network.commit.interaction' distinguish between 'file' and 'function' artifact networks Signed-off-by: Leo Sendelbach <[email protected]>
One simple test for each artifact network configuration (either 'file' or 'function') Signed-off-by: Leo Sendelbach <[email protected]>
It now uses the correct vertices depending on the configuration of either 'file' or 'function'. Signed-off-by: Leo Sendelbach <[email protected]>
Tests now expect the correct vertex kind Signed-off-by: Leo Sendelbach <[email protected]>
vertices now have the correct 'kind' attribute also restructured if statements in artifact network construction Signed-off-by: Leo Sendelbach <[email protected]>
Same points as before with more references to commits Signed-off-by: Leo Sendelbach <[email protected]>
Warning is now uniform with other warnings in project Signed-off-by: Leo Sendelbach <[email protected]>
Also made small changes to testing data to include a commit with specified function and added a warning that should only occur when the commit-interaction data was generated incorrectly Signed-off-by: Leo Sendelbach <[email protected]>
Now uses a custom handler for type 'int' that converts the int to a string, which lets us read the 'region' value for the commits Signed-off-by: Leo Sendelbach <[email protected]>
Fix style issues, modify README.md, add small test and add some comments for clarity Signed-off-by: Leo Sendelbach <[email protected]>
Also add more available edge attributes to network construction Signed-off-by: Leo Sendelbach <[email protected]>
Some links to Codeface in our README.md still pointed to siemens/codeface, which had been archived already two years ago. Instead of these outdated links, we link to the se-sic/codeface repository now. This partly addresses #272. Signed-off-by: Thomas Bock <[email protected]>
Add functions to compute a developer's last activity Reviewed-by: Maximilian Löffler <[email protected]> Merged-by: Thomas Bock <[email protected]>
Base implementation for new classification metrics. Documentation and testing still missing. Signed-off-by: Leo Sendelbach <[email protected]>
Tests use already existing network, this test cases are quite small. Additional research into potential rounding errors may be required. Signed-off-by: Leo Sendelbach <[email protected]>
Add default documentation, same as for already existing classification methods Signed-off-by: Leo Sendelbach <[email protected]>
add new entry under 'unversioned" Signed-off-by: Leo Sendelbach <[email protected]>
Also minor fixes as requested in PR Signed-off-by: Leo Sendelbach <[email protected]>
Changed ordering in readme Signed-off-by: Leo Sendelbach <[email protected]>
tests hierarchy with network previously used for another unit test Signed-off-by: Leo Sendelbach <[email protected]>
formulation change as requested Signed-off-by: Leo Sendelbach <[email protected]>
NEWS.md now includes update to README Signed-off-by: Leo Sendelbach <[email protected]>
expanded descripotion of network-based metrics to make clear that they can be used on any type of network Signed-off-by: Leo Sendelbach <[email protected]>
also changed some wording issues in NEWS and README Signed-off-by: Leo Sendelbach <[email protected]>
also corrected copyright headers Signed-off-by: Leo Sendelbach <[email protected]>
Changed comment explaining potential issues with hierarchy classification Signed-off-by: Leo Sendelbach <[email protected]>
Putting the verb before the adverb Signed-off-by: Leo Sendelbach <[email protected]>
implemented feedback on PR Signed-off-by: Leo Sendelbach <[email protected]>
Additional Core/Peripheral Classification Methods Reviewed-by: Thomas Bock <[email protected]> Reviewed-by: Christian Hechtl <[email protected]>
This commit works towards #260. Signed-off-by: Thomas Bock <[email protected]>
As of `ggplot2` version 3.5.0, the function `discrete_scale`, which is used for `plot.network` in coronet, does not require a `scale_name` parameter anymore. Even more, this parameter has been deprecated. Therefore, we also don't use it any more in coronet. However, as a consequence of this, the plotting module of coronet requires `ggplot2` version 3.5.0 or higher, as of now. Signed-off-by: Thomas Bock <[email protected]>
Signed-off-by: Thomas Bock <[email protected]>
Replace deprecated function calls and parameters Reviewed-by: Thomas Bock <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #280 +/- ##
=========================================
Coverage ? 81.69%
=========================================
Files ? 16
Lines ? 5146
Branches ? 0
=========================================
Hits ? 4204
Misses ? 942
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Thomas Bock <[email protected]>
Signed-off-by: Thomas Bock <[email protected]>
Heartfelt thanks to @Leo-Send, @maxloeffler, and @hechtlC for your contributions to this amazing new release of coronet! I will merge right away and release our new version. |
5.0
Announcement
coronet
is not compatible withigraph
versions below 2.1.0 anymore. This is due to the simultaneous deprecation ofsubgraph.edges
and the introduction of the replacement for it,subgraph_from_edges
, inigraph
version 2.1.0.coronet
is not compatible withggplot2
versions below 3.5.0 anymore. This is due to the simultaneous deprecation of thescale_name
parameter ofdiscrete_scale
(which is used within the functionplot.network
ofcoronet
) inggplot2
version 3.5.0.Added
read.commit.interactions
for reading, as well asget.commit.interactions
,set.commit.interactions
, and utility functions for working with commit-interaction data (PR Adding commit-interactions #252, d82857f, b4fd2a2, fd0aa05, bca3576, PR Add Commit Networks #263, 849123a, 3fb7437, 170bc66, f591528) as well as tests for these features (PR Adding commit-interactions #252, eeba7e2, 8bb39f4, 54b6f65, 7a5497a, 7b8585f, ef72540)create.author.network
orcreate.artifact.network
if theartifact.relation
orauthor.relation
is configured to becommit.interaction
(PR Adding commit-interactions #252, d82857f, 329d97e) as well as tests for these features (PR Adding commit-interactions #252, 07e7ed7, 7068cfa)add.vertex.attribute.commit.network
for adding vertex attributes to a commit network (PR Add Commit Networks #263, ab73271, ab73271, cd9a930)remove.duplicate.edges
function that takes a network as input and conflates identical edges (PR Miscellaneous improvements regarding network splitting and simplification #268, d9a4be4, 0c2f47c, c6e90dd)cumulative
as an argument toconstruct.ranges
which enables the creation of cumulative ranges from given revisions (PR Miscellaneous improvements regarding network splitting and simplification #268, a135f6b, 8ec207f)get.last.activity.data
to compute developers' last activities in a project, as well as functionadd.vertex.attribute.author.last.activity
to add a developer's date of last activity as vertex attribute to a network, as well as helper functionsget.aggregated.activity.data
andadd.vertex.attribute.author.aggregated.activity
to allow for other activity aggregations than first and last activity (PR Add functions to compute a developer's last activity #275, 9f23161, 8660ed7)util-read.R
(PR Adding commit-interactions #252, f8ea987)coverage.R
(PR Integrate code coverage metric into CI #262, 10cac49, b3b9f4a, c815d18, e809352, 32d0482)util-misc.R
andutil-networks.R
(PR Fix igraph deprecation warnings as well as a bug in issue network construction #264, ff30f32, af80551)Changed/Improved
coronet
networks with certainigraph
functionality since igraph version 2.1.0 (PR Change default representation of edge attributes from vectors to lists & other miscellaneous adjustments #274, 1c35d1f, eda30b8, 0c6b2eb, 44c7b72, 7303eab, 0c27012)issues.from.source
configuration parameter. Instead of reading JIRA and GitHub issues together, which was the previous default, the new default value causes only GitHub issue data to be read. To restore the previous default behavior and read data from both issue sources, this now needs to be manually configured when needed. (PR Fix igraph deprecation warnings as well as a bug in issue network construction #264, 5ff83c3, 8c8080c, 8bcbc81)igraph
functions by their preferred alternatives (PR Fix igraph deprecation warnings as well as a bug in issue network construction #264, PR Miscellaneous improvements regarding network splitting and simplification #268, PR Change default representation of edge attributes from vectors to lists & other miscellaneous adjustments #274, PR Replace deprecated function calls and parameters #279, 0df9d5b, 7ac840d, e3617b8, 4b0d522, f29662b)ggplot2::discrete_scale
(PR Replace deprecated function calls and parameters #279, 027ce79)construct.edge.list.from.key.value.list
to be more readable (PR Add Commit Networks #263, 05c3bc0)igraph
version to 2.1.0 inREADME.md
(PR Change default representation of edge attributes from vectors to lists & other miscellaneous adjustments #274, 6c3bcd1)ggplot2
version to 3.5.0 inREADME.md
(PR Replace deprecated function calls and parameters #279, 027ce79)README.md
(PR Additional Core/Peripheral Classification Methods #276, 6101e11, c6744c0, 5fc2da5)Fixed
split.network.time.based.by.ranges
. This effect also propagates intosplit.networks.time.based
(PR Change default representation of edge attributes from vectors to lists & other miscellaneous adjustments #274, 87911ad)extract.timestamps
that occurs when the firstdata.source
contains empty data and that leads to a return value of type numeric which should be POSIXct (PR Fix a bug in 'extract.timestamps' when dealing with an empty data source #270, 10696e4, 646c01a)metrics.scale.freeness
andmetrics.is.scale.free
functions to be compatible with both older and newer igraph versions (PR Change default representation of edge attributes from vectors to lists & other miscellaneous adjustments #274, 4b0d522)