Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang is supported everywhere now #299

Merged
merged 2 commits into from
Jan 9, 2024
Merged

clang is supported everywhere now #299

merged 2 commits into from
Jan 9, 2024

Conversation

axel-h
Copy link
Member

@axel-h axel-h commented Jan 9, 2024

This is following up on the comment #297 (comment), we can use clang everywhere as the builds seem to work fine. So remove the blockers here, they should be put into specific workflow the in case there are still issues.

Test run is here: https://github.com/axel-h/seL4/actions/runs/7464262889/job/20310849733?pr=137 (added dummy for RV32; removed some HW platforms so the build does not take ages)

@axel-h axel-h requested a review from lsf37 as a code owner January 9, 2024 15:46
Copy link
Member

@lsf37 lsf37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, looks good.

Thanks for providing the test runs. I've checked the plain base images for hifive and tx1 on the machine queue and they appear to work without problems, so I'm happy to let this loose on the bigger test runs and see if they all work.

@lsf37 lsf37 merged commit 739bd6d into seL4:master Jan 9, 2024
7 checks passed
@axel-h axel-h deleted the patch-axel-5 branch January 10, 2024 08:13
@lsf37
Copy link
Member

lsf37 commented Jan 11, 2024

Ok, so there is one clang issue remaining after all: on TX1, the combination of SMP+HYP+MCS fails consistently with clang (and does succeed for gcc).

See e.g. https://github.com/seL4/seL4/actions/runs/7468884979/job/20367008152?pr=1156

They are getting stuck (timing out) on

<testcase classname="sel4test" name="SCHED_CONTEXT_0014">
  Running test SCHED_CONTEXT_0014 (Test deleting a scheduling context while it runs out of budget on another core)

Unless you have an immediate fix, I'd exclude that combination from the test for now and open an issue for it.

@axel-h
Copy link
Member Author

axel-h commented Jan 11, 2024

I don't have a fix here.

@lsf37
Copy link
Member

lsf37 commented Jan 11, 2024

Ok, see #301 now. Turns out this issue already exists for the TX2 and ODROID_C4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants