aarch64/riscv64: make the microkit loader relocatable #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alwin-joshy
force-pushed
the
relocatable
branch
from
e8da997 to
6058c13
Compare
alwin-joshy
force-pushed
the
relocatable
branch
from
3b471a8 to
4bc689d
Compare
|
Added support for RISC-V. Tested on star64 by loading image at address 0x70000000 (LOADER_LINK_ADDRESS is 0x60000000) |
alwin-joshy
force-pushed
the
relocatable
branch
from
4bc689d to
807591c
Compare
alwin-joshy
changed the title
Ivan-Velickovic
requested changes
Feb 3, 2025
There was a problem hiding this comment.
This would be great to get in before the next release. Main thing that would be good to change is to have the loader print if it is relocating itself and to where within memory it is relocating itself. This kind of thing tends to be fragile and so its good to print that info in debug mode.
So, the first thing the loader should do is still jump to main where it decides whether it needs to relocate itself or not, and print appropriately.
alwin-joshy
force-pushed
the
relocatable
branch
2 times, most recently
from
c6c2dd7 to
a9beb22
Compare
This allows a microkit image to be loaded anywhere in memory at which point it will relocate itself to the LOADER_LINK_ADDRESS. These changes are based on the elfloader from seL4/seL4_tools. Changes include: * crt0.s was changed to crt0.S and compiled with gcc to pass in LINK_ADDRESS * memmove and memcpy implementations were added * loader_data was changed to include a size field. This is the size of loader_data, the list of regions, and the regions themselves. These also need to be relocated to ensure that everything works correctly Signed-off-by: Alwin Joshy <[email protected]>
Ivan-Velickovic
force-pushed
the
relocatable
branch
from
a9beb22 to
7c327d3
Compare
This allows a microkit image to be loaded anywhere in memory at which point it will relocate itself to the LOADER_LINK_ADDRESS. These changes are based on the elfloader from seL4/seL4_tools. See previous commit for more details. Signed-off-by: Alwin Joshy <[email protected]>
Signed-off-by: Alwin Joshy <[email protected]>
With the changes to seL4 regarding reserving the SBI region properly [1] it means we can no longer use 0x80200000 as a loader link address for this platform. [1]: seL4/seL4@cf3a64b Signed-off-by: Ivan Velickovic <[email protected]>
Signed-off-by: Ivan Velickovic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a microkit image to be loaded anywhere in memory at which point it will relocate itself to the LOADER_LINK_ADDRESS. These changes are based on the elfloader from seL4/seL4_tools.
Changes include:
Tested on: imx8mm with LOADER_LINK_ADDRESS = 0x41000000 and uboot load address parameter set to 0x42000000